Topic: Filename trailing dots cut-off (Read 13030 times)

newuzer · « **on:** 09 October 2020, 16:03 »

Hi Roman,

MAME 0.225 Software Lists CHDs, pc98_cd.xml

<software name="toshin2s">
<disk name="toushin toshi ii - soshite, sorekara..." sha1="10ae6ad7d25f19f4af5dc51953c733496b14b5b2" />

Results in "toushin toshi ii - soshite, sorekara.chd".
If renamed according to the XML, clrmamepro insists on renaming it back.

Code: [Select]

Toushin Toshi II - Soshite, Sorekara... [folder: toshin2s - size: 0]
wrong name: E:\mamesecret\MAME-Software-List-CHDs\MAME 0.225 Software List CHDs (merged)\pc98_cd\toshin2s\toushin toshi ii - soshite, sorekara....chd [wrong: toushin toshi ii - soshite, sorekara....chd] [right: toushin toshi ii - soshite, sorekara.chd]

I agree, it's a nasty label

I've therefor also consulted MAMEdev to look at the label name (and similar ones).
Is it (to your knowledge) a convention that trailing dots are (supposed to be) ignored?

Regards, NU.

Roman · « **Reply #1 on:** 09 October 2020, 18:22 »

I will have a look

newuzer · « **Reply #2 on:** 09 October 2020, 19:13 »

MAMEdev responded with a fix for the named set.
https://github.com/mamedev/mame/commit/3d7aef469cb6b0e6db423b11bbd3bd22e7d35e8e
They will also add checks to -validate to go through the labels and check for CHDs with extensions or otherwise.

It's still interesting to investigate whether it's correct behavior or not.
I think clrmamepro acts by MAME design/convention, that extension separators (.) should not be part of the (file) label.

NU.

ArconEmu · « **Reply #3 on:** 10 October 2020, 00:35 »

I think the correct character in this case would be 'Horizontal Ellipsis' = '…', see: https://www.fileformat.info/info/unicode/char/2026/index.htm
But I'm not sure if that is supported by MAME.

But naturally that depends whether your OS supports it or not.

Roman · « **Reply #4 on:** 10 October 2020, 08:45 »

I found the part in the source code already which is responsible for trimming the dots at the end.
Assume it gets fixed for the next version.

I remember why I added it. Actually you cannot create a folder under windows with a "." at the end. You can successfully run a mkdir test. from commandline and you can even make a dir test. but it will appear without the dot and a dir test will do the same.
But you can create files with dots at the end...so I will remove the trimming.

Roman · « **Reply #5 on:** 10 October 2020, 17:00 »

https://mamedev.emulab.it/clrmamepro/binaries/cmpro20201010.7z

newuzer · « **Reply #6 on:** 11 October 2020, 19:58 »

Thanks Roman, but...
The requested URL /clrmamepro/binaries/cmpro20201010.7z was not found on this server.

Roman · « **Reply #7 on:** 11 October 2020, 20:01 »

because I've just updated the link to today

News:

Author Topic: Filename trailing dots cut-off (Read 13030 times)

newuzer

Filename trailing dots cut-off

Roman

Re: Filename trailing dots cut-off

newuzer

Re: Filename trailing dots cut-off

ArconEmu

Re: Filename trailing dots cut-off

Roman

Re: Filename trailing dots cut-off

Roman

Re: Filename trailing dots cut-off

newuzer

Re: Filename trailing dots cut-off

Roman

Re: Filename trailing dots cut-off