EMULAB Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

The new forum is online, hope you enjoy it!

Pages: 1 [2]   Go Down

Author Topic: auto rename same-name different-hash roms on merge  (Read 9933 times)

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 93
  • Offline Offline
  • Posts: 2855
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.125 Chrome 36.0.1985.125
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #20 on: 12 August 2014, 09:37 »

Oddi....

hap renamed a dozens files in MAME ;-) and the current official cmpro asks you if you want to remove parent/clone relationship or force split-merge mode...

my own build does something else already.....which was described earlier in this thread...

Guess a new cmpro comes mid/late next week....
Logged

oxyandy

  • Member
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 266
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Firefox 29.0 Firefox 29.0
    • View Profile
    • .
Re: auto rename same-name different-hash roms on merge
« Reply #21 on: 12 August 2014, 09:42 »

What about a BETA for testing Roman ?  ::)
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 93
  • Offline Offline
  • Posts: 2855
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.125 Chrome 36.0.1985.125
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #22 on: 12 August 2014, 10:37 »

when I resolved your rebuilder thingie....

maybe...not much time this week....will see....
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 93
  • Offline Offline
  • Posts: 2855
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.143 Chrome 36.0.1985.143
    • View Profile
Logged

oddi

  • Member
  • *
  • Karma: 2
  • Offline Offline
  • Posts: 178
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 32.0 Firefox 32.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #24 on: 14 August 2014, 17:51 »

Hi Roman, cmp20140814.rar <-- clean cache, option "Parse Rom merge tag" enable, cmp crashed :(
That is that fast first test
CMP crash of 1942 set , me watch new subfolder inside archives ( 18w.7z ) , now try play with qmc2 games from subfolder for test.
« Last Edit: 14 August 2014, 18:20 by oddi »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 93
  • Offline Offline
  • Posts: 2855
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.143 Chrome 36.0.1985.143
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #25 on: 14 August 2014, 19:29 »

yep it crashes....will look at it later (maybe next week)....and I removed the package....

I know what it is (index error...most likely based on the change of name and resort....)...but I need some more time next week to find the (most likely simple) root issue...

so...delete the build and use the official cmpro ;-)
« Last Edit: 14 August 2014, 20:17 by Roman »
Logged

oddi

  • Member
  • *
  • Karma: 2
  • Offline Offline
  • Posts: 178
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 32.0 Firefox 32.0
    • View Profile
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 93
  • Offline Offline
  • Posts: 2855
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.143 Chrome 36.0.1985.143
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #27 on: 15 August 2014, 09:07 »

too much reading...for me here at work...

let the mamedevs work on the naming...and avoiding name/hash conflicts...

generally the cmpro part is to somehow preserve the naming and the parent/clone relationship...and I guess the idea of having subfolders is ok...

but again, it's up to devs to avoid such things in a first way (while still keeping their naming convention)....
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 93
  • Offline Offline
  • Posts: 2855
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.143 Chrome 36.0.1985.143
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #28 on: 18 August 2014, 20:51 »

well...in the meantime I found the (pretty obvious sorting) bug which caused the index issue with the test build.....and fixed it..
However I'm not really happy with the solution...

ok...it would rename hash/name collisions to "setname\filename" ...but it currently it does it to resolve the problem only...which means that it will only rename file with the found collision in one set...not the other....

Example:

Parent: A, B, C
Clone 1: D, E, F
Clone 2: D, G, H (where this D != D from the previous clone)

and this ends with:

Parent: A, B, C
Clone1: Clone1/D, E, F
Clone2: D, G, H

Currently I'm thinking if it would be better to also rename the second D:
Parent: A, B, C
Clone1: Clone1/D, E, F
Clone2: Clone2/D, G, H


...and what if the parent is part of the hash collision....should the parent keep the name while only the clones change?


Parent: A, B, C, D
Clone1: Clone1/D, E, F
Clone2: Clone2/D, G, H

or

Parent: A, B, C, Parent/D
Clone1: Clone1/D, E, F
Clone2: Clone2/D, G, H



.... waiting for ideas .....
« Last Edit: 18 August 2014, 20:52 by Roman »
Logged

oddi

  • Member
  • *
  • Karma: 2
  • Offline Offline
  • Posts: 178
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 31.0 Firefox 31.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #29 on: 19 August 2014, 05:29 »

Roman, i like the last idea:

Parent: A, B, C, Parent/D
Clone1: Clone1/D, E, F
Clone2: Clone2/D, G, H

I think it would be neatly, my opinion :)

Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 93
  • Offline Offline
  • Posts: 2855
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.143 Chrome 36.0.1985.143
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #30 on: 19 August 2014, 08:35 »

actually my current favorite is

Parent: A, B, C, D
Clone1: Clone1/D, E, F
Clone2: Clone2/D, G, H


so only affected clone files may get a subfolder
« Last Edit: 19 August 2014, 08:36 by Roman »
Logged

f205v

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 95
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Opera 12.17 Opera 12.17
    • View Profile
    • EMMA dumping team
Re: auto rename same-name different-hash roms on merge
« Reply #31 on: 19 August 2014, 08:46 »

I do agree with Roman.
In case of merged sets, it would be logical to have the parent (which is somewhat considered "the perfect set" in MAME) into the root of the zipfile, and the various clones into their subdirectory inside the zip.
IMHO this should be valid for all sets, not only for sets with name collisions. It will have both the advantage of a single zipfile (as it is in merged sets now-a-day) and of a humanly readable structure to separate parent from clones (as it is in split sets now-a-day)
Just my 2 cents. Eurocents, off-course!  ;)
Logged
-------------
ciao
f205v

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 93
  • Offline Offline
  • Posts: 2855
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.143 Chrome 36.0.1985.143
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #32 on: 19 August 2014, 09:00 »

well...yes...I can consider this, too....instead of the hash collision warning a general option to allow to store clones as subfolders...

however, this would only be needed if you got fully merged sets.....and since you can switchmerge modes whenever you want I would need to have a dynamic filename getter....depending on the used merge mode...like

string getFileName() {
  if (full_merge and (user_wants_subfolders or is_hash_collision_file)) {
    return "setname\filename";
  }
  return filename;
}


hmmm...interesting....need to think about this a bit...
Logged

oddi

  • Member
  • *
  • Karma: 2
  • Offline Offline
  • Posts: 178
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 31.0 Firefox 31.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #33 on: 19 August 2014, 09:20 »

Parent: A, B, C, D
Clone1: Clone1/D, E, F
Clone2: Clone2/D, G, H

this is the subfolders ?

me think that is name of files
"name of clone set"_D,E,F
"name of clone set"_D,G,H

dont like idea with subfolders , sorry.

example with any set:
parent - 1942.7z / roms : a.rom b.rom
clone - 1942a.7z / roms: b.rom c.rom
clone 1942b.7z / roms: b.rom d.rom
and blabla
After merge sets have only one set 1942.7z
inside have :
---
a.rom
1942_b.rom
1942a_b.rom
c.rom
1942b_b.rom
d.rom
 
and etc etc


« Last Edit: 19 August 2014, 09:25 by oddi »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 93
  • Offline Offline
  • Posts: 2855
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.143 Chrome 36.0.1985.143
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #34 on: 19 August 2014, 09:35 »

Sorry Oddi but we (well, at least some MAME devs and myself like the idea) do want archive subfolders ;-)

The goal is to keep as much original database information from MAME as possible...so altering the filenames should be a no-go....putting them into a set-subfolder (in full merged mode) however sounds pretty ok to me...

again, this only affects full merged sets...and only the structure within the archives would change.....


Logged

oddi

  • Member
  • *
  • Karma: 2
  • Offline Offline
  • Posts: 178
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 31.0 Firefox 31.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #35 on: 19 August 2014, 11:41 »

Ok Roman , me think about that " The goal is to keep as much original database information from MAME as possible." , yep u are right.
Go to subfolders :)
Logged
Pages: 1 [2]   Go Up
 

Page created in 0.071 seconds with 22 queries.

anything