EMULAB Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

The new forum is online, hope you enjoy it!

Pages: [1] 2   Go Down

Author Topic: auto rename same-name different-hash roms on merge  (Read 9685 times)

hap

  • Karma: 0
  • Offline Offline
  • Posts: 7
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Firefox 31.0 Firefox 31.0
    • View Profile
auto rename same-name different-hash roms on merge
« on: 05 August 2014, 18:39 »

This is the message that pops up when Clrmame finds a rom inside a clone that has the same name as one in the parent but a different hash:

"Issue:   Can't merge set due to equal names for different ROM hashes
Press yes to remove parent/clone relationship or no to force split-merge mode."

Instead of that, how about this? "Press yes to rename this file to origname(__setname).xx or no to force split-merge mode.".

Since Clrmame is the most-used rom manager, currently MAME goes all the way around this issue and forces to have names of roms like that itself. IMO it'd be cleaner if this was done inside Clrmame instead, for people that want a completely merged romset.
Logged


Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 88
  • Offline Offline
  • Posts: 2803
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.125 Chrome 36.0.1985.125
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #1 on: 05 August 2014, 19:08 »

hmm...but then you do alter a rom name.....and I already hear people complaining about that (even if MAME itself does not care since it loads by hash value)...I thought removing the parent/clone relationship is the less evil thing here to do...
....besides of this I guess 99% of MAME users use split sets....

well.....maybe we can keep that up for discussion.....
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 88
  • Offline Offline
  • Posts: 2803
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.125 Chrome 36.0.1985.125
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #2 on: 05 August 2014, 19:40 »

hmm...on a second thought....since cmpro supports set subfolders (and I think MAME load routine should be able to handle that, too)....I may think about changing it from "origname" to "setname\origname"...

Logged

hap

  • Karma: 0
  • Offline Offline
  • Posts: 7
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Firefox 31.0 Firefox 31.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #3 on: 05 August 2014, 20:14 »

Ah indeed, that's a better idea, didn't think of it.
Even if you take away nameclashes, it is a much cleaner way for a fully merged romset rather than throwing it all under 1 folder.
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 88
  • Offline Offline
  • Posts: 2803
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.125 Chrome 36.0.1985.125
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #4 on: 05 August 2014, 20:34 »

yeah....I will run some tests....
Logged

oxyandy

  • Member
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 266
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Firefox 29.0 Firefox 29.0
    • View Profile
    • .
Re: auto rename same-name different-hash roms on merge
« Reply #5 on: 06 August 2014, 13:56 »

I brought this issue up previously:
Honestly I don't like the sub-folder idea..
I'd be happy with
Some_rom.ext
to
Some_rom.ext_alt
Seeing MAME doesn't care about file-names at all.

EDIT: Oh maybe I wasnt thinking deep enough..
Do you mean  ??
Parent.zip
\parent\rom.1
\parent\rom.2
\clone_1\rom.1
\clone_2\rom.1
« Last Edit: 06 August 2014, 14:32 by oxyandy »
Logged

oxyandy

  • Member
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 266
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Firefox 29.0 Firefox 29.0
    • View Profile
    • .
Re: auto rename same-name different-hash roms on merge
« Reply #6 on: 06 August 2014, 14:06 »

Oh, and there's this:



By default, is unticked, so many people end up making a Merged - say t7z ROM set:
1. Which takes longer to process (make)
2. Ends up with archives which are larger & with more (internal) files than needed.

« Last Edit: 06 August 2014, 15:36 by oxyandy »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 88
  • Offline Offline
  • Posts: 2803
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.125 Chrome 36.0.1985.125
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #7 on: 06 August 2014, 14:36 »

I brought this issue up previously:
Honestly I don't like the sub-folder idea..
I'd be happy with
Some_rom.ext
to
Some_rom.ext_alt
Seeing MAME doesn't care about file-names at all.

EDIT: Oh maybe I wasnt thinking deep enough..
Do you mean  ??
Parent.zip
\parent\rom.1
\parent\rom.2
\clone_1\rom.1
\clone_2\rom.1


close but not it....only if you got a hash collision you'd get a subfolder for that one file...
so
parent.zip is
rom.1, rom.2, rom.3, clone_x\rom.3, clonerom.1

(where rom.1 to rom.3 are parent roms, rom.3 in clone_x is different from its parent nad clonerom.1 is a real clone file)
Logged

oddi

  • Member
  • *
  • Karma: 2
  • Offline Offline
  • Posts: 178
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 32.0 Firefox 32.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #8 on: 06 August 2014, 15:08 »

Hi Oxy, about this option "Rom Parse merge tag" tick or untick ?
My cmpro this option is unticked, when it's on cmpro wanna rename mass roms !!!
Which is right, btw my Mame sets it's t7z/merged
Tnx:)
Little screen from my cmpro:
« Last Edit: 06 August 2014, 15:10 by oddi »
Logged

oxyandy

  • Member
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 266
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Firefox 29.0 Firefox 29.0
    • View Profile
    • .
Re: auto rename same-name different-hash roms on merge
« Reply #9 on: 06 August 2014, 16:04 »

@Roman ::) Thanks, I understand your intention now :)

@Oddi, yes CMP 'says' it wants to rename those files:
BUT, I think you will find that name already exists in the archive with matching CRC
So, CMP will not Rename them, it will delete them ..

Parse ROM 'merge' tags
Makes archives with less internal files, and a smaller total size archive..
You could try a few (copied from your current set) watch what CMP does to them ;)
« Last Edit: 06 August 2014, 16:05 by oxyandy »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 88
  • Offline Offline
  • Posts: 2803
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.125 Chrome 36.0.1985.125
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #10 on: 06 August 2014, 16:28 »

well...regarding rom merge tags...

they were pretty wrong and several times broken in the past within MAME's listxml output. Cmpro finds wrong merge tags and I think by now it should be pretty stable within MAME.

it's all about your interpretation how a clean set should look like....should it contain all database listed items, correctly named...then you should turn it off...
If you care more about as-compact-as-possible sets, turn it on....then you may loose the information about rom names withing clones...since MAME tries to name the roms after the actual ICs on the board, you may have hash identical roms with different names within parent/clone relationships...

..it's just a matter of taste...maybe I turn the option on by default for the next release....
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 88
  • Offline Offline
  • Posts: 2803
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.125 Chrome 36.0.1985.125
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #11 on: 06 August 2014, 20:19 »

ok...took a MAME .149 database (since someone (hehehe) fixed such hash clashes lately in MAME), turned rom merge parsing on and looked at the bombjack sets which had a hash clash back then....

So instead of having the parent clone relationship removed, you end up with something looking like the attached picture....(yes...a subfolder...in your archive)
Logged

hap

  • Karma: 0
  • Offline Offline
  • Posts: 7
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Firefox 31.0 Firefox 31.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #12 on: 06 August 2014, 20:47 »

cool =)
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 88
  • Offline Offline
  • Posts: 2803
  • Operating System:
  • Mac OS X Mac OS X
  • Browser:
  • Safari 7.0 Safari 7.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #13 on: 07 August 2014, 05:45 »

user would still see a prompt during data read in though.....will see if this is really needed
Logged

hap

  • Karma: 0
  • Offline Offline
  • Posts: 7
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Firefox 31.0 Firefox 31.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #14 on: 10 August 2014, 20:11 »

Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 88
  • Offline Offline
  • Posts: 2803
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 36.0.1985.125 Chrome 36.0.1985.125
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #15 on: 10 August 2014, 20:21 »

hahaha....damn you... ;-)
Logged

oddi

  • Member
  • *
  • Karma: 2
  • Offline Offline
  • Posts: 178
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 32.0 Firefox 32.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #16 on: 12 August 2014, 09:05 »

Hello guys , whastup with the last Mame svn code ? Strange job, i build and scan with the last cmp forum build and the last svn mame dat. CMP wanna remove and rename mass roms, when i click on, cmp create different sets names with same roms inside.
tnx:)
Logged

oxyandy

  • Member
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 266
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Firefox 29.0 Firefox 29.0
    • View Profile
    • .
Re: auto rename same-name different-hash roms on merge
« Reply #17 on: 12 August 2014, 09:14 »

Hi Oddi,
@Reply #6
Do you still have "Parse ROM 'merge' tags" ticked ?

BTW, I always keep it ticked, my reasons explained above ^^
« Last Edit: 12 August 2014, 09:16 by oxyandy »
Logged

oddi

  • Member
  • *
  • Karma: 2
  • Offline Offline
  • Posts: 178
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 32.0 Firefox 32.0
    • View Profile
Re: auto rename same-name different-hash roms on merge
« Reply #18 on: 12 August 2014, 09:16 »

No, untick atm, must tick for future ?

[PS] When is ticked , cmp report many warnings - "same roms name with different hashesh" rename or remove and bla bla ..
chaos
Where is the truth ? :))))
Found the truth ! , Roman and mamedevs want to make my life hard. :P :P :P
« Last Edit: 12 August 2014, 09:26 by oddi »
Logged

oxyandy

  • Member
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 266
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Firefox 29.0 Firefox 29.0
    • View Profile
    • .
Re: auto rename same-name different-hash roms on merge
« Reply #19 on: 12 August 2014, 09:28 »

Quote
No, untick atm, must tick for future ?

Ask yourself :)
Do you want a merged ROM set, which:
1. Takes less time to process, cause it has less total files (Yes still passes perfect audit in EMU)
2. Makes a smaller 'total sized' set.

Maybe you should Re-read my & Roman's earlier replies .

Ok then, about the 'other' changes
See Hap's reply earlier, not sure how much he has done, but clearly he has taken to doing 'some' ROM renaming ;)
Logged
Pages: [1] 2   Go Up
 

Page created in 0.173 seconds with 20 queries.