EMULAB Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

The new forum is online, hope you enjoy it!

Pages: 1 [2] 3   Go Down

Author Topic: Clrmamepro 64 bits crash under wine64  (Read 638 times)

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.87 Chrome 80.0.3987.87
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #20 on: 06 February 2020, 20:12 »

ok...I've replaced AfxBeginThread with CreateThread calls...let's give it a try:

https://mamedev.emulab.it/clrmamepro/binaries/threadcmpro64.zip
Logged

vicmarto

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • OS:
  • Mac OS X 10.14.6 Mac OS X 10.14.6
  • Browser:
  • Safari 13.0.4 Safari 13.0.4
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #21 on: 07 February 2020, 12:24 »

ok...I've replaced AfxBeginThread with CreateThread calls...let's give it a try:

https://mamedev.emulab.it/clrmamepro/binaries/threadcmpro64.zip

Wow! Seems we are doing some big progress, finally Clrmamepro opens without crash!. Not only that, but everything seems to work correctly: load MAME dat, scanner and rebuilder (zip, 7z and rar). Very happy!

Here is the new log:

Code: [Select]
testing cache file version
delete cache
show welcome message / clean cache message
get Current Time
test button bitmaps
check window sizes
check for update
init 7z lib
test 7z rename
test 7z rename test remove
test 7z rename test compress
test 7z rename test remove
test rar rename test remove
test rar rename test compress
test rar rename test remove
parse engine
prepare main dialog
set bitmaps
build window
default profiler
run profiler
init profiler
running profiler
init profiler
running profiler

Just a little glitch, when clicking [X] to close the Clrmamepro window, it crashed, it's not important but I preferred to said it. Attached is the backtrace.txt.

ok...I've replaced AfxBeginThread with CreateThread calls...

Can this call change from AfxBeginThread to CreateThread be integrated into the normal clrmamepro?

(however AfxBeginThread is also used in the 3rd party zip library....)
This is to compress or to decompress? Like I said before, seems both compress and decompress are ok.

A big thanks,

vicmarto
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.87 Chrome 80.0.3987.87
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #22 on: 07 February 2020, 13:11 »

I will check what's happening on "exit" ;)
I don't know yet if the change from AfxBeginThread to CreateThread will make it since there are warnings out there to prefer AfxBeginThread over CreateThread which is a bit low level C runtime.....but I will check it....The current test build lacks setting the priority of the threads by the way...it was just a quick check to see if this is really related to that function.
Also I have to check where exaclty AfxBeginThread is used in the 3rd party lib (only did a quick text search on the sources)....

Thanks for testing
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.87 Chrome 80.0.3987.87
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #23 on: 08 February 2020, 19:06 »

let's first find the exit problem...
https://mamedev.emulab.it/clrmamepro/binaries/exitcmpro64.zip

removed old log entries, added new ones just for closing
Logged

vicmarto

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • OS:
  • Mac OS X 10.14.6 Mac OS X 10.14.6
  • Browser:
  • Safari 13.0.4 Safari 13.0.4
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #24 on: 09 February 2020, 02:56 »

Thanks again Roman.

This is the new log:

Code: [Select]
onclose
ondestroy
save settings
free global memfile
unload button
delete 7z
remove empty dirs
remove temp www
free global
save lists
save global
save profiler xml
free logger

And the backtrace is attached.

Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.87 Chrome 80.0.3987.87
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #25 on: 09 February 2020, 08:07 »

interesting....since it runs till the end. Have to check what some class destructors do then...
Logged

vicmarto

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • OS:
  • Mac OS X 10.15.3 Mac OS X 10.15.3
  • Browser:
  • Safari 13.0.5 Safari 13.0.5
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #26 on: 19 February 2020, 10:08 »

Hi Roman, did you take a look at those class destroyers? Thank you!
« Last Edit: 19 February 2020, 10:09 by vicmarto »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.116 Chrome 80.0.3987.116
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #27 on: 19 February 2020, 10:39 »

sorry to not coming back to you earlier....really busy with real life at the moment. Yes, I had a look...but don't see anything wrong in there. Actually after the free logger only one from my destructors is called and "of course it works on my system" ;-)
After that only internal general win32 api closing stuff is called.....

but I try to have a look at it again this week....
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.116 Chrome 80.0.3987.116
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #28 on: 19 February 2020, 20:18 »

https://mamedev.emulab.it/clrmamepro/binaries/exit2cmpro64.zip

very minor change...and I highly doubt it changes anything....but who knows ;-)
Logged

vicmarto

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • OS:
  • Mac OS X 10.15.3 Mac OS X 10.15.3
  • Browser:
  • Safari 13.0.5 Safari 13.0.5
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #29 on: 20 February 2020, 13:01 »

https://mamedev.emulab.it/clrmamepro/binaries/exit2cmpro64.zip

very minor change...and I highly doubt it changes anything....but who knows ;-)

Roman: I don't know what you did, but you're a genius, really. I'm so happy, thank you a thousand times!  ;D

Now, if only the changes could be merged...  8)

Code: [Select]
onclose
ondestroy
save settings
free global memfile
unload button
delete 7z
remove empty dirs
remove temp www
free global
save lists
save global
save profiler xml
free logger
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.116 Chrome 80.0.3987.116
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #30 on: 20 February 2020, 13:12 »

so no crash I guess? Interesting ;-)
Logged

vicmarto

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • OS:
  • Mac OS X 10.15.3 Mac OS X 10.15.3
  • Browser:
  • Safari 13.0.5 Safari 13.0.5
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #31 on: 20 February 2020, 13:51 »

I spoke too soon, seems some engines don't crash and others crashes  :o

For me it's already as is. But, if you want to experiment more, I would be happy to help!

Code: [Select]
onclose
ondestroy
save settings
free global memfile
unload button
delete 7z
remove empty dirs
remove temp www
free global
save lists
save global
save profiler xml
free logger

Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.116 Chrome 80.0.3987.116
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #32 on: 20 February 2020, 14:08 »

what do you mean exactly with "some engines don't crash", others crash?
what did you do? Does it crash if you only start and directly quit? Does it crash if you start, load a profile, quit? etc...
can you describe the steps from start to end when it crashes?
Logged

vicmarto

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • OS:
  • Mac OS X 10.15.3 Mac OS X 10.15.3
  • Browser:
  • Safari 13.0.5 Safari 13.0.5
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #33 on: 20 February 2020, 14:43 »

Only start and then quit is enough to crash it. These are all the steps. Only crash at exit, using the program is all ok!!  :o

About "some engines crash, some don't": I'm talking about different wine versions, for example:
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.116 Chrome 80.0.3987.116
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #34 on: 20 February 2020, 14:48 »

use Wine64 5.1 and 5,2 then ;-)
Logged

vicmarto

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • OS:
  • Mac OS X 10.15.3 Mac OS X 10.15.3
  • Browser:
  • Safari 13.0.5 Safari 13.0.5
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #35 on: 20 February 2020, 14:48 »

Yes, it's OK!!  ;D
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.116 Chrome 80.0.3987.116
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #36 on: 20 February 2020, 16:34 »

Did the old version (https://mamedev.emulab.it/clrmamepro/binaries/exitcmpro64.zip) crash in Wine64 5.1 and 5,2?
Logged

vicmarto

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • OS:
  • Mac OS X 10.15.3 Mac OS X 10.15.3
  • Browser:
  • Safari 13.0.5 Safari 13.0.5
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #37 on: 20 February 2020, 16:39 »

Eeeerrr, sorry for confusion: no, they are not crashing.
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 80
  • Offline Offline
  • Posts: 2701
  • OS:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 80.0.3987.116 Chrome 80.0.3987.116
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #38 on: 20 February 2020, 17:03 »

ok...so I can blame github.com/PhoenicisOrg/winecx ;-)
Logged

vicmarto

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • OS:
  • Mac OS X 10.15.3 Mac OS X 10.15.3
  • Browser:
  • Safari 13.0.5 Safari 13.0.5
    • View Profile
Re: Clrmamepro 64 bits crash under wine64
« Reply #39 on: 20 February 2020, 17:05 »

Yes, I was thinking the same  ;D
Logged
Pages: 1 [2] 3   Go Up
 

Page created in 0.2 seconds with 22 queries.

anything