EMULAB Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

The new forum is online, hope you enjoy it!

Pages: 1 2 [3]   Go Down

Author Topic: error while unpacking warning - clrmamepro 4.014a  (Read 35138 times)

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 115
  • Offline Offline
  • Posts: 3297
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 34.0.1847.116 Chrome 34.0.1847.116
    • View Profile
Re: error while unpacking warning - clrmamepro 4.014a
« Reply #40 on: 15 April 2014, 20:03 »

hmm..but it's not fixed with this here:

http://mamedev.emulab.it/clrmamepro/binaries/cmpro64_ii.rar


or is it....? (found something which looked a bit odd...but should not harm...but who knows...)
Logged

Baines

  • Karma: 0
  • Offline Offline
  • Posts: 12
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 28.0 Firefox 28.0
    • View Profile
Re: error while unpacking warning - clrmamepro 4.014a
« Reply #41 on: 15 April 2014, 20:57 »

hmm..but it's not fixed with this here:

http://mamedev.emulab.it/clrmamepro/binaries/cmpro64_ii.rar


or is it....? (found something which looked a bit odd...but should not harm...but who knows...)

Still fails.  It doesn't seem to break anything new, but the same stuff that failed before still fails.

---------------------------
cmpro64
---------------------------
error while unpacking 7z file C:\Users\Billy\Emulation\ClrMamePro\apple.7z

file: cmpro.ini
dest:
index: 1
testMode: 1
reqCRC: 617F2616
calcCRC: 00000000
bCRC32: 0
result: 1
---------------------------
OK   
---------------------------
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 115
  • Offline Offline
  • Posts: 3297
  • Operating System:
  • Mac OS X Mac OS X
  • Browser:
  • Safari 7.0 Safari 7.0
    • View Profile
Re: error while unpacking warning - clrmamepro 4.014a
« Reply #42 on: 15 April 2014, 20:59 »

oh wait...bcrc32 is 0..... this is interesting!
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 115
  • Offline Offline
  • Posts: 3297
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 34.0.1847.116 Chrome 34.0.1847.116
    • View Profile
Logged

Baines

  • Karma: 0
  • Offline Offline
  • Posts: 12
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 28.0 Firefox 28.0
    • View Profile
Re: error while unpacking warning - clrmamepro 4.014a
« Reply #44 on: 15 April 2014, 22:47 »

and test 3...


http://mamedev.emulab.it/clrmamepro/binaries/cmpro64_iii.rar

And it works!

At least it worked for everything that I threw at the About pane.

EDIT: Quick test, I don't see it throwing warnings in the Rebuilder either.
« Last Edit: 15 April 2014, 22:50 by Baines »
Logged

Baines

  • Karma: 0
  • Offline Offline
  • Posts: 12
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 28.0 Firefox 28.0
    • View Profile
Re: error while unpacking warning - clrmamepro 4.014a
« Reply #45 on: 15 April 2014, 23:01 »

Down side is that I forgot to mention a different issue that I ran across when testing...

Files can be identified with CRC, sha1, and md5.  The Rebuilder cares if the sha1 and md5 of a file doesn't match the DAT information.  The Scanner, and the Scanner's "Fix Name" function, doesn't.

When I was testing, I for some reason rigged two files with identical CRCs, but different contents (and thus different sha1 and md5).  I made a DAT for one of the roms.  If I archive the other instead manually and stick it in the Rom directory and run a Scan, CMP looks at its CRC, sees the match, and decides that it is the proper file even though the sha1 and md5 don't match.  If it has a different name, CMP decides it is the right file and just has the wrong name, and setting Fix Name will have it rename the file.

There is an Advanced option to test sha1/md5 for Fix Missing, but not to enable it for the basic scan, and not as a safety for Fix Name.

(Ah, I remember why I did it.  I was trying to see whether the Rebuilder was actually checking the sha1/md5 of destinations when set.)

EDIT: I could have worded this report better.  I meant to say that this was an issue from the start, not something introduced in one of the fixes.
« Last Edit: 15 April 2014, 23:08 by Baines »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 115
  • Offline Offline
  • Posts: 3297
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 34.0.1847.116 Chrome 34.0.1847.116
    • View Profile
Re: error while unpacking warning - clrmamepro 4.014a
« Reply #46 on: 16 April 2014, 07:12 »

For your new thingie, would be great to have the files so I can do some tests...


back to the 7z one, well, it's not Windows 8's fault...neither 7zips...it was mine...
Welcome to the world of "funny things happen if you don't initialize variables".....
There was a boolean flag within a structure which decides if the CRC32 should be calculated or not....in one case this boolean inside the structure was not initialized, so actually the value is random...Funnily enough for all systems except Windows 8.1/64bit/64bit cmpro it accidently took the right value (true) and it worked well....for you it took false....

Nice finding...such things can drive you crazy....resolved....guess I put out a new version tonight/tomorrow...
Logged

oxyandy

  • Member
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 269
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Firefox 25.0 Firefox 25.0
    • View Profile
    • .
Re: error while unpacking warning - clrmamepro 4.014a
« Reply #47 on: 16 April 2014, 08:54 »

There is an Advanced option to test sha1/md5 for Fix Missing, but not to enable it for the basic scan, and not as a safety for Fix Name.
Yeah well on a plus side a CRC collision is rare, as you say Rebuilder takes cares of it. (on source side)
But, for this to happen on a set with 2 files in the same set sharing duplicate CRC32 but different SHA
on DAT change/update would be infinitely rarer !

Is all about speed.
But is good to know the extra "Scanner" option "Additionally......." is there.

@Baines, what you explained is very clear. Conclusion: not a big deal.
Great work providing Roman with clues  8)
« Last Edit: 16 April 2014, 09:55 by oxyandy »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 115
  • Offline Offline
  • Posts: 3297
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 34.0.1847.116 Chrome 34.0.1847.116
    • View Profile
Re: error while unpacking warning - clrmamepro 4.014a
« Reply #48 on: 16 April 2014, 09:01 »

Yeah...enabling it for name/unneeded checks would make it crawl ;-)

Better run a sha1 check afterwards.....
Logged
Pages: 1 2 [3]   Go Up
 

Page created in 0.161 seconds with 20 queries.

anything