EMULAB Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

The new forum is online, hope you enjoy it!

Pages: [1]   Go Down

Author Topic: problem with xml lists and comments  (Read 8135 times)

etabeta

  • Karma: 0
  • Offline Offline
  • Posts: 111
  • Operating System:
  • Mac OS X 10.6.3 Mac OS X 10.6.3
  • Browser:
  • Safari 4.0.5 Safari 4.0.5
    • View Profile
problem with xml lists and comments
« on: 14 July 2010, 06:50 »

hi Roman,

the MESS list you can find at

http://git.redump.net/cgit.cgi/mess/plain/hash/einstein.xml

is not correctly loaded in clrmame (you can add it, but it does not show up in the new profile folder). the problem seems to be that the list, despite being a well formed xml file, contains too many lines of comments at the top of the file, and this in some way makes clrmame behave in this strange way (if I manually move the comments at the bottom of the file, everything works fine)

is this something you can avoid or should I move large comments to the bottom in the future?
Logged


Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Firefox 3.6.6 Firefox 3.6.6
    • View Profile
Re: problem with xml lists and comments
« Reply #1 on: 14 July 2010, 08:18 »

clrmame's profiler got a line limit to detect various types of xml datfiles...simply for speed reason...it checks...let's say 128 lines (have to look up the value) to see if it found enough information to decide if it's listxml, offlinexml, hyperblabla...etc..

Moving the comments to the end will of course solve it......increasing the number count, too (maybe I should move the value in the config file...).

I will think about it.....however holiday time starts soon....maybe a quick release before...no idea yet ;)
Logged

etabeta

  • Karma: 0
  • Offline Offline
  • Posts: 111
  • Operating System:
  • Mac OS X 10.6.3 Mac OS X 10.6.3
  • Browser:
  • Safari 4.0.5 Safari 4.0.5
    • View Profile
Re: problem with xml lists and comments
« Reply #2 on: 14 July 2010, 09:31 »

what does clrmame look for to decide it's a MESS xml list? I could move the comments after the <softwarelist> line (a place I would prefer instead of the bottom of the file), if it is enough...
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Firefox 3.6.6 Firefox 3.6.6
    • View Profile
Re: problem with xml lists and comments
« Reply #3 on: 14 July 2010, 10:08 »

Good question...I don't know without looking at the source...but I think it checks for the first game listed....
Logged

etabeta

  • Karma: 0
  • Offline Offline
  • Posts: 111
  • Operating System:
  • Mac OS X 10.6.3 Mac OS X 10.6.3
  • Browser:
  • Safari 4.0.5 Safari 4.0.5
    • View Profile
Re: problem with xml lists and comments
« Reply #4 on: 14 July 2010, 15:58 »

could you change it to look for <softwarelist> in place of <software>? or at least to something like: if clrmame finds a <softwarelist> item in the first X lines, then check for the first entry to see if it's a <software> without line limits...

not knowing in which way you recognize dat/xml files, it's definitely hard to suggest alternative way to handle (with the least code changes) ;)
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Windows 7 Windows 7
  • Browser:
  • Firefox 3.6.6 Firefox 3.6.6
    • View Profile
Re: problem with xml lists and comments
« Reply #5 on: 14 July 2010, 20:13 »

fixed for next version...if it finds a doctype mess/mame/software list it directly marks the dat as detected...
Logged
Pages: [1]   Go Up
 

Page created in 0.195 seconds with 19 queries.

anything