Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Roman]

3.131b

fixed: rename wizard's 'keep parent' option isn't working

[Roman]

hmmm...actually I'm still not happy with that option...
I think I will change it in something like:

if the old set was a parent and is renamed to a non-parent in the new dat, you can use the option to allow this or not.

Background is that artworkdats usually keep parent set pngs....and frontends usually show the parent png if clone ones aren't given....

[s_bastian]

the best thing IMHO would be a "if parent is moved to clone, but no new parent set is available, keep the old image as parent renaming it accordingly". In this way a parent image will always be available, even in not 100% correct

[Roman]

"if parent is moved to clone, but no new parent set is available

Hmm...a bit more tricky than the "don't rename if parent is renamed to a clone" (which I included last night already)...but I will do some brainstorming about it....

[Roman]

hmm...actually I think you can't get this information from the 2 dats...

let's assume this switch of 2 sets:

SetA (parent in old dat) -> SetB (clone in new dat)
SetB (clone in old dat -> SetA (parent in new dat)

Your rule would allow both renames.....

If now the artwork123 datfile holds only SetA.png, apply the changes will make it to a SetB.png....which is a clone....this may result in the fact that only clone shows the picture....(hope this was clear...)

My rule however would not allow the first rename (so it would stay SetA) but would allow the second rename...which will cause a "double rename"....hmm...again, not the best solution....need to handle this as well.

[TurkMame]

Hi Roman,
At the attached picture you can see there is something with some of the latest releases.(i dont know when it was started).
For both download options it shows the clone name.seond one should be parent name.the link is correct.only the writing is wrong.i think you forgot the variable name same for both .

Thanks for your great work.

[s_bastian]

hmm...actually I think you can't get this information from the 2 dats...

let's assume this switch of 2 sets:

SetA (parent in old dat) -> SetB (clone in new dat)
SetB (clone in old dat -> SetA (parent in new dat)

Your rule would allow both renames.....

If now the artwork123 datfile holds only SetA.png, apply the changes will make it to a SetB.png....which is a clone....this may result in the fact that only clone shows the picture....(hope this was clear...)

You got me wrong, my option included also the statement "but no new parent set is available". Maybe that point was not very clear and misleading, I'll try to better explain:

In MAME dats you have:
0.134->0.135
SetA->SetB, from parent to clone
SetB->SetC, from clone to parent, used C for clearer explanation, but could be B or whatever
SetD=SetD another clone, unchanged

In artwork123 you only have SetA
With the "double rename" rule, SetA.png is changed in SetB.png. If you load mameUI 0.135, the image is shown only in SetB, being now a clone properly renamed. This might be OK for sets like the title one, where very often each image refers to the exact version of the game being loaded

With the "check if parent exists", SetA would be renamed in SetC (parent). This because no SetB.png existed in artwork123 BEFORE the rename. Rebuilding with this dat would allow to see, in mameUI 0.135, images in all SetX. With the same option enabled, if in artwork123 both SetA and SetB existed, they would have BOTH renamed, accordingly to the mame dat.

Clearer now? Not easy but again, this is IMO the best option

[Roman]

Hi Roman,
At the attached picture you can see there is something with some of the latest releases.(i dont know when it was started).
For both download options it shows the clone name.seond one should be parent name.the link is correct.only the writing is wrong.i think you forgot the variable name same for both .

Thanks for your great work.

fixed for next version

[Roman]

With the "check if parent exists", SetA would be renamed in SetC (parent). This because no SetB.png existed in artwork123 BEFORE the rename.

hmmm....that means I need to analyze the 3rd dat/to be modified dat, too....hmm...something I wanted to avoid.

[TurkMame]

Thanks man.
With the work for renaming sets(parent-->clone;clone-->parent) and same roms with different name in parent-clone we will no more do handwork.
it will be great.

[Roman]

With the "check if parent exists", SetA would be renamed in SetC (parent).

Yiekes....nah....I don't think it makes sense. Ok, the 'parent stays parent' rule would fit but if the old parent shows e.g. a japanese flyer png and the new set 'C' shows a completely different title/language (there are such cases where clones do differ a lot) you will show a wrong flyer (as the original author might wanted to).

Hope I find some time at the weekend to rethink this whole thing....

[s_bastian]

sure, that is a risk, and that's why it should be an OPTION. It should be up to user to choose based on their will. Some want to be precise in everything, and for therm the "double rename" is the right way. For people just willing to see ANY image, or for collection of "parent only" like emumovie's AVI or Scuore's parent only, the "check if parent exist" it what they need!

[Roman]

aren't you mixing up double-rename here? The "allow double rename option" only checks if two old sets are renamed to the same new one.

So generally, no restrictions to parent/clone renaming should be done when creating the rename list...don't care for double of parent/clone renames....that list should stay the same...

...but when applying the renames to a nother dat, it should avoid double-renaming (i.e. not creating two equally named pngs...) and handle parent/clone handling (where the parent/clone relationships come from the old/new dats and not the 3rd-to-be-modified dat....which is a bit...hmm...annoying )

[s_bastian]

sorry for my wrong use of terms. As double rename I meant:

SetA (parent in old dat) -> SetB (clone in new dat)
SetB (clone in old dat -> SetA (parent in new dat)