EMULAB Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

The new forum is online, hope you enjoy it!

Pages: [1]   Go Down

Author Topic: Difference in CMP & scannerui with SL  (Read 5599 times)

Bad A. Billy

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 15
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Difference in CMP & scannerui with SL
« on: 07 August 2024, 04:47 »

Roman,

   Couple of questions that just popped up for me on this MAME update and some peculiar results I got scanning the software lists.
If you look at the 2 attached png's you'll see all the missing chd's from the scans. First scan I had all the missing files in the correct places and CMP said everything was fine. I then scanned it with the latest new scanner and it told me I had a lot of unneeded files so I went through and moved all those files aside manually( Whilst doing this I also came across some unneeded directories and some that were misnamed and fixed those thanks to your new scanner.).
Re-scanned and scanner was A-OK now but CMP told me I was missing all those files. I also noticed that all of the files were clones so I dug a little deeper into the xml's. All the files are the same or share others with parents they just have a different file in the set. Either a different 1st or 2nd chd or as I found out, especially with the fmtowns_cd SL, they have a floppy to boot from that the other doesn't.

   My scans were done with the same MAME.exe on the same drive with the last CMP and the latest new scanner version. I do this with every new release every month so here's my questions:

Why hasn't the new scanner pointed these out before v.268? Something that was changed?
I have them both set to split sets so the new scanner is correct but CMP is wrong?
I didn't see any changes to those specific SL's this month so I'm just trying to figure out what changed. These are the same files I've been scanning and fixing since they were added to MAME.
Sorry this got a little longer than I wanted...

Otherwise it seems that your new scanner is doing a great job! Saved me about 4gb of unneeded files this month.

    Again, thanks for all your hard work!! A lot of people out here really appreciate what you're doing!
Logged


Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3425
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Re: Difference in CMP & scannerui with SL
« Reply #1 on: 07 August 2024, 08:33 »

ok...two problems here:

1) id Anthology and gran turismo 2, well, currently I don't have an idea why they popped up as unneeded now for you. The information hasn't changed in the 287-288 cycle....Can you verify the chd if it really matches (e.g. a chdman info / verify...or a rebuild with the new rebuilder ;-)). If something failed while reading the header information of these files, it might lead to the unneeded message...but as I said...currently no idea.

2) the general issue with the clone chds. Old cmpro's full-combined mode is wrong here (so most likely the old -listsoftware list parser). It does not apply merging information on the disks. If the cdi hash file is loaded as a single profile it's ok.See attached screenshot which shows the difference of the combined and single mode (at lease you can spot the different texts colors indicating a clone file or not). I guess I can fix that in old cmpro. So well, the new scanner is right, old cmpro combined mode is wrong.



Update: I've already fixed 2) (collecting other stuff before a release happens though)
« Last Edit: 07 August 2024, 09:58 by Roman »
Logged

Bad A. Billy

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 15
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Re: Difference in CMP & scannerui with SL
« Reply #2 on: 07 August 2024, 12:50 »

Thanks Roman.

1- I will check out those chd's tonight when I get a chance.
2- That's what I had figured was happening but had hoped it was something on my end and didn't mean a fix on CMP's end.

Thx again & I'll let you know on the 1st issue as soon as I can.
Logged

Bad A. Billy

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 15
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Re: Difference in CMP & scannerui with SL
« Reply #3 on: 08 August 2024, 02:50 »

Ok, no big mystery on these 2. They are also clones and share chd's with the parent.

Scanner seems to be working as it should. Good deal!

Thanks for the help!
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3425
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Re: Difference in CMP & scannerui with SL
« Reply #4 on: 08 August 2024, 08:06 »

ah, so it's the same problem for gta and idanthology....Had another look at the filenames again...yeah...so...for now, trust the new scanner and not the combined old cmpro mode ;-)
Thanks for testing and reporting.
Logged

Bad A. Billy

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 15
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Re: Difference in CMP & scannerui with SL
« Reply #5 on: 11 August 2024, 05:35 »

Roman - Got an update for you...

I went ahead and updated my back-up drive and tried a couple of things that came to mind to test. Most worked or I figured out.

**( Ignore this one for now, I am going to double check this again and get back to you on it(unless you know offhand that it does delete them.))**
- This is from the fmtowns_cd issue from before. The scanner does delete the clone chds and leaves the "floppyname.zip" in the main folder but then leaves the empty chd folder behind and only marks it as unneeded. It does not delete it.

 - Question- I imagine at some point you are going to add a confirmation dialog for fixes? Sorry if that's been asked before but I don't recall seeing it...

 - This is probably a stupid question but here goes. In the attached screenshot I have set tp show all complete, partial, fully missing & empty machines/sets. It's not showing what those 114 empty machines are that I have circled. I know it's not devices & such, there's a lot more than 114 of those. What exactly is missing there?

      Thanks again!
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3425
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Re: Difference in CMP & scannerui with SL
« Reply #6 on: 11 August 2024, 13:47 »

I will have a look at the fmtowns_cd issue with keeping the empty chd folder. A confirmation prompt for fixes .... I put it on the wish list, not planned yet ;-)
The 114 empty ones and they don't appear...interesting....no idea at the moment...I will have a look ;)

Thanks for testing / reporting
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3425
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Re: Difference in CMP & scannerui with SL
« Reply #7 on: 11 August 2024, 15:08 »

Sure you got "complete" enabled?
Because I only see the fmtowns output and since there is no filtering, what about all the complete software lists?

If a software list is complete, you'd only see a filled green circle for e.g. "Commodore 128 catridges", and no sub machines in there even no empty ones.
This is most likely hiding empty machines.

I can create a list of the 114 "empty" ones if you like but I guess they simply belong to software lists which aren't listed (and are complete if I'm not mistaken). Maybe I add an option also show complete machines on software list level, however depening on what you got, the tree might be relatively big which takes time to render (unless I make it dynamic with a lazy-draw-on-expand thing)...
Logged

Bad A. Billy

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 15
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Re: Difference in CMP & scannerui with SL
« Reply #8 on: 12 August 2024, 05:16 »

Double checked the empty folder issue and it's definitely there as you can see in the 1st 3 attachments. Says they are unneeded but just doesn't want to get rid of them...

Yes, I have it set to complete(see last screenshot) and those are still in there but I understand what you're saying about it not showing those too. It would still be nice to have the option of showing them listed somewhere though if for nothing else, just to know where things belong if there was a problem to troubleshoot. I checked by adding the main roms folder with only -listsoftware active and none of those are included with the main xml lists. They are still missing if you include the regular -listxml list.

Another oddity that I don't know if you can answer or not. I had a couple of folders in my SL that the scanner said were unneeded but have hash files in MAME's hash folder. They are also available on Pleasuredome's Github. 1 example I can recall would be "advantage". I searched though MAME and the source on github but can't find anything that uses it.

Carbeena is another system oddball that got added and has it's own SL xml in hash, but scanner says it doesn't belong in SL. I guess maybe this is more of a mamedev SL question/problem than 1 for you?

Side note: On the expansions in the viewer is there a way to expand all at once or is that a WIP still?

      Thanks a whole lot Roman!
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3425
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Re: Difference in CMP & scannerui with SL
« Reply #9 on: 12 August 2024, 05:52 »

Thanks for the screenshots, I will definetly look into the folder and not-showing-empty issue.
Regarding -listsoftware vs MAME hashfolder issue: Yes, MAME's -listsoftware output does not include all hashfiles. The reason: Well, guess you need to ask a MAMEDev about it. Maybe some flag specifying that a hashfile should not yet be included in the full list or something. I don't have an answer for that, but it's known since the beginning of -listsoftware ;)

Update #1: Well, the output of the fmtowns empty folders is correct though. It finds a zip file and the empty folder for a machine where the machine doesn't have any chds on its own. So it says it founds a dupe (multiple machine) and does not remove any of the two. The actual problem is when it moved/removed the chd before, there it forgets to remove the folder.

Update #2: Showing (complete and/or empty) machines on completed sl level is now in
Update #3: Auto expand tree feature is now in

Update #4: the removal of the empty folders is now fixed... (besides other stuff) ... now I only got 3 minor nice-2-have things from my side to add before I put out a new version....still no combined rebuilder/scanner though.
« Last Edit: 15 August 2024, 19:06 by Roman »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3425
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 127.0.0.0 Chrome 127.0.0.0
    • View Profile
Re: Difference in CMP & scannerui with SL
« Reply #10 on: 17 August 2024, 15:17 »

Sneak peek....(new version most likely next week...)

Core:
- added: long path/filename support (32k)

- misc:  scanner: propagate changed file timestamp up to rom/samplepath level

- fixed: erroneously allow \ as an machine name character
- fixed: scanner, freeze when fixing unneeded decompressed files (or chds) (0.02.1)
- fixed: scanner, wrong named files which are also fill-ins for missing files can trigger an obsolete file removal operation (sdiamond MAME.268)
- fixed: scanner, unneeded files/folders contain multiple identical entries (aa3020 MAME.268)
- fixed: scanner, fixing a wrong named folder failed when additional pattern folders were involved (copy error)
- fixed: scanner, fixing a wrong named folder failed when folder can have multiple new names (aa3020/a3010/aa5000 MAME.268)  (move error)
- fixed: scanner, prefered path lookup for software list collections never returned additional pattern folders (copy error)
- fixed: scanner, prefered path lookup for wrong named machines which only consist of chds failed (freeze during backup)
- fixed: scanner, removal of unneeded files can result in an empty folder which isn't removed

UI:
- added: scanner, always have software list collection sublevels (before a complete sl list only showed the complete top level)
- added: scanner, context menu option to auto expand scan results tree
- added: scanner, context menu list options are now also available on software list level

- fixed: active paths are not always remembered correctly when switching xmls or on initial load
- fixed: scanner, empty sofware lists show complete instead of empty icon
- fixed: scanner, scan results tree/log split isn't refreshed after minimizing/maximizing window
« Last Edit: 17 August 2024, 15:18 by Roman »
Logged
Pages: [1]   Go Up
 

Page created in 0.065 seconds with 22 queries.