EMULAB Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

The new forum is online, hope you enjoy it!

Pages: [1]   Go Down

Author Topic: Rom rename issue in 4.04  (Read 15673 times)

Dariusz

  • Karma: 0
  • Offline Offline
  • Posts: 5
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • MS Internet Explorer 9.0 MS Internet Explorer 9.0
    • View Profile
Rom rename issue in 4.04
« on: 10 March 2012, 21:51 »

Hi

I am scanning mame roms (0.0145) with clrmamepro (v4.04) using the fix options enabled (ie. ticked).

I get the following message on about two dozen roms:

"
Set:   Cadillacs and Dinosaurs (World 930201)
Name:   dino
File:   G:\EMULATOR_ROMS\Mame_ArcadeRoms_145\dino.zip

Do you want to rename the following wrong named ROMs?

cd_q.rom -> cd_q.5k
cd_q1.rom -> cd-q1.1k
cd_q2.rom -> cd-q2.2k
cd_q3.rom -> cd-q3.3k
cd_q4.rom -> cd-q4.4k
cde_21a.rom -> cde_21a.6f
"
When I select 'Yes'  or 'Yes to All', the renaming does not occur. (ie. the next time I scan, the same question occurs).

I cannot figure out why the renaming is not working.

I am running Windows 7, and I run Clrmamepro in 'Run as Administrator'.

I look forward to anyones help.

D
Logged


Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 118
  • Offline Offline
  • Posts: 3329
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 17.0.963.78 Chrome 17.0.963.78
    • View Profile
Re: Rom rename issue in 4.04
« Reply #1 on: 11 March 2012, 12:26 »

renaming can fail if

a) the zipfile got bad structures...so it might decompress fine but some zip specific structures are bad and renaming fails
b) rename a file to a new name which already exists in the archive and no circular rename takes place. In this case you need to do it manually (or simply rebuild the set)

I can look at it if you send me the archive in question.
Logged

B2K24

  • Member
  • *
  • Karma: 2
  • Offline Offline
  • Posts: 29
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Firefox 10.0.2 Firefox 10.0.2
    • View Profile
Re: Rom rename issue in 4.04
« Reply #2 on: 11 March 2012, 20:48 »

I have same issue upgrading a MAME romset from 0.145u3 to 0.145u4

Right now the only solution is to manually move the zips which generate a prompt to some temp directory and use the rebuilder which rebuilds them back in correctly.

I think the issue is sometimes a file with same CRC32 has different names in the same zip.

I hoping these zips can help this progress Roman :)

http://www.sendspace.com/file/cm270r
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 118
  • Offline Offline
  • Posts: 3329
  • Operating System:
  • Mac OS X Mac OS X
  • Browser:
  • Safari 5.1 Safari 5.1
    • View Profile
Re: Rom rename issue in 4.04
« Reply #3 on: 12 March 2012, 07:31 »

I will look at the files. However keep in mind that some rene failures are a wanted behaviour.
For example: imagine a zip with file A and B in it.
And a rename of A -> B without a rename of B to something. Then rename fails.
Logged

max-holz

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 18
  • Operating System:
  • Windows Server Home/Server 2003 Windows Server Home/Server 2003
  • Browser:
  • Firefox 10.0.2 Firefox 10.0.2
    • View Profile
Re: Rom rename issue in 4.04
« Reply #4 on: 12 March 2012, 09:43 »

There are 12 cases of this kind upgrading to 145u4 with my merged romset:
China Town Club (Bellfruit) (set 1) (Scorpion 1) [folder: sc1china - size: 192kb]
wrong name: C:\MAME\roms\sc1china\39371857.p1 [wrong: 39371857.p1] [right: club-china-town_dat_ac_200pnd_ass.bin] [not fixed]
Cash Attraction (Bellfruit) (set 1) (Scorpion 1) [folder: sc1cshat - size: 256kb]
wrong name: C:\MAME\roms\sc1cshat\95728.20 74-78 proto a.bin [wrong: 95728.20 74-78 proto a.bin] [right: 957282.20 74-78 proto a.bin] [not fixed]
Cash Wise (Bellfruit) (set 1) (Scorpion 1) [folder: sc1cshwz - size: 192kb]
wrong name: C:\MAME\roms\sc1cshwz\cashwisep1.bin [wrong: cashwisep1.bin] [right: 95727210a 74-78 sw.bin] [not fixed]
wrong name: C:\MAME\roms\sc1cshwz\cashwisep2.bin [wrong: cashwisep2.bin] [right: 95727211b 74-78 sw.bin] [not fixed]
Double Chance (Bellfruit) (set 1) (Scorpion 1) [folder: sc1dblch - size: 288kb]
wrong name: C:\MAME\roms\sc1dblch\95000110_dc_sound_2 [wrong: 95000110_dc_sound_2] [right: doublechancesnd1.bin] [not fixed]
wrong name: C:\MAME\roms\sc1dblch\95000111_dc_sound_1 [wrong: 95000111_dc_sound_1] [right: doublechancesnd2.bin] [not fixed]
Fun House Club (Bellfruit) (set 1) (Scorpion 1) [folder: sc1funh - size: 192kb]
wrong name: C:\MAME\roms\sc1funh\club-fun-house_std_ac_ass.bin [wrong: club-fun-house_std_ac_ass.bin] [right: club-fun-house_std_ac_a.bin] [not fixed]
wrong name: C:\MAME\roms\sc1funh\club-fun-house_std_ac_bss.bin [wrong: club-fun-house_std_ac_bss.bin] [right: club-fun-house_std_ac_b.bin] [not fixed]
Grand Slam (Bellfruit) (Dutch) (Scorpion 1) [folder: sc1gslam - size: 192kb]
wrong name: C:\MAME\roms\sc1gslam\grandslam_snd_a.bin [wrong: grandslam_snd_a.bin] [right: gslsnd1.bin] [not fixed]
wrong name: C:\MAME\roms\sc1gslam\grandslam_snd_b.bin [wrong: grandslam_snd_b.bin] [right: gslsnd2.bin] [not fixed]
Winning Streak (Bellfruit) (set 1) (Scorpion 1) [folder: sc1winst - size: 576kb]
wrong name: C:\MAME\roms\sc1winst\95717110 proto var% b.bin [wrong: 95717110 proto var% b.bin] [right: 95717110 var% b.bin] [not fixed]
Willow (USA) [folder: willow - size: 4mb]
wrong name: C:\MAME\roms\willow\wl_36.12h [wrong: wl_36.12h] [right: wlu_36.12h] [not fixed]
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 118
  • Offline Offline
  • Posts: 3329
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Chrome 17.0.963.79 Chrome 17.0.963.79
    • View Profile
Re: Rom rename issue in 4.04
« Reply #5 on: 12 March 2012, 10:08 »

As mentioned before, please check if this is not intended....
zipfile contains A and B; rename A -> B where B is not renamed either...then you will get this...

This will currently show a not-fixed message simply because you'd otherwise either create double zip entries (B and B) or would overwrite a valid file.
I may think of a move to backup maybe.....
Logged

max-holz

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 18
  • Operating System:
  • Windows Server Home/Server 2003 Windows Server Home/Server 2003
  • Browser:
  • Firefox 10.0.2 Firefox 10.0.2
    • View Profile
Re: Rom rename issue in 4.04
« Reply #6 on: 12 March 2012, 12:51 »

I solved moving these sets in the backup folder and doing a rebuilding. I don't how it's possible but it works!
I have tested Willow and clones and all are working fine.
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 118
  • Offline Offline
  • Posts: 3329
  • Operating System:
  • Windows XP Windows XP
  • Browser:
  • Chrome 17.0.963.79 Chrome 17.0.963.79
    • View Profile
Re: Rom rename issue in 4.04
« Reply #7 on: 12 March 2012, 13:36 »

Well of course rebuilding "works" and solves this, since you don't do renames :) The rebuilder just adds/replaces files. In case of a replace, the replaced one gets moved to backup.

Again, a rename checks if the new_name exists, then the rename operation won't be done (unless the existing new_name gets renamed by itself).

Guess I should apply the 'move to backup if rename fails' logic to roms (for sets it's already in)...
Logged
Pages: [1]   Go Up
 

Page created in 0.162 seconds with 21 queries.