Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[newuzer]

Hi roman,

In regard to:
https://github.com/mamedev/mame/commit/56ef8b14a2af3117decb113a78c4efb7ab182e56
Line 131 "jp1_mpr0.2c." ends up "jp1_mpr0.2c" in the zipfile.
Even though a (now fixed) bug in the MAME source, IMO the trailing dot should not be trimmed.

Regards, NU.

[Roman]

You cant have a file in windows which ends with a dot if I remember correctly. Keep in mind you can have your sets unpacked. I will look at it though.

[newuzer]

You cant have a file in windows which ends with a dot if I remember correctly.

You're correct, but Windows cuts it off by itself.
Can it have that name in the zipfile?
Perhaps (also) an "Invalid filename" warning?

Thanks, NU.

[Roman]

If I‘m not mistaken the used zip archive library also auto kills the dot even if a filename in the zipstructure can have a dot at the end. As soon as you try to work with unpacked data you will run into issues since the filename wont match anymore and in cmpro the loaded dat defines the name and it doesnt differ between packed or unpacked files.
There are simply a number of illegal chars which cant be used and will always create issues (:/\|<> etc).
Since it is fixed in the mame source I doubt something will be changed in cmpro and mame loads files by hash and not by name anyway.