EMULAB Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

The new forum is online, hope you enjoy it!

Pages: [1]   Go Down

Author Topic: CMP trims trailing dot in ROM name  (Read 521 times)

newuzer

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Firefox 90.0 Firefox 90.0
    • View Profile
CMP trims trailing dot in ROM name
« on: 28 July 2021, 15:46 »

Hi roman,

In regard to:
https://github.com/mamedev/mame/commit/56ef8b14a2af3117decb113a78c4efb7ab182e56
Line 131 "jp1_mpr0.2c." ends up "jp1_mpr0.2c" in the zipfile.
Even though a (now fixed) bug in the MAME source, IMO the trailing dot should not be trimmed.

Regards, NU.
« Last Edit: 28 July 2021, 15:47 by newuzer »
Logged


Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 102
  • Offline Offline
  • Posts: 3064
  • Operating System:
  • Mac OS X Mac OS X
  • Browser:
  • Safari 14.1.1 Safari 14.1.1
    • View Profile
Re: CMP trims trailing dot in ROM name
« Reply #1 on: 28 July 2021, 16:53 »

You cant have a file in windows which ends with a dot if I remember correctly. Keep in mind you can have your sets unpacked. I will look at it though.
Logged

newuzer

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Firefox 90.0 Firefox 90.0
    • View Profile
Re: CMP trims trailing dot in ROM name
« Reply #2 on: 28 July 2021, 18:19 »

You cant have a file in windows which ends with a dot if I remember correctly.
You're correct, but Windows cuts it off by itself.
Can it have that name in the zipfile?
Perhaps (also) an "Invalid filename" warning?

Thanks, NU.
« Last Edit: 28 July 2021, 19:32 by newuzer »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 102
  • Offline Offline
  • Posts: 3064
  • Operating System:
  • Mac OS X Mac OS X
  • Browser:
  • Safari 14.1.1 Safari 14.1.1
    • View Profile
Re: CMP trims trailing dot in ROM name
« Reply #3 on: 28 July 2021, 19:51 »

If I‘m not mistaken the used zip archive library also auto kills the dot even if a filename in the zipstructure can have a dot at the end. As soon as you try to work with unpacked data you will run into issues since the filename wont match anymore and in cmpro the loaded dat defines the name and it doesnt differ between packed or unpacked files.
There are simply a number of illegal chars which cant be used and will always create issues (:/\|<> etc).
Since it is fixed in the mame source I doubt something will be changed in cmpro and mame loads files by hash and not by name anyway.
Logged
Pages: [1]   Go Up
 

Page created in 0.088 seconds with 22 queries.

anything