Topic: Work In Progress (Read 50872 times)

oxyandy · « **Reply #60 on:** 23 August 2011, 07:12 »

Just tell me from what I sent....
Just deleting a single entry is enough to reproduce the crash...

The solution and cause, well that can wait..

Roman · « **Reply #61 on:** 23 August 2011, 07:52 »

well, currently I'm at work and have to fiddle with JS/XSLT and soap requests

You have to wait approx 10 hours....
but this really sounds like an array access tries to get data from a previous (now invalid index due to deletion) and that leads to a crash....sounds pretty easy to fix as soon as I found the place...but I still wonder why this happens after a long batch job where no index is removed or added..anyway...I will check it...

oxyandy · « **Reply #62 on:** 23 August 2011, 18:53 »

<a href="http://www.upload.ee/image/1602829/relog.swf" target="_blank" rel="noopener noreferrer" class="bbc_link bbc_flash_disabled new_win">http://www.upload.ee/image/1602829/relog.swf</a>

Tick, Tock.

3.10am local time, 31 Celsius, 75% Humidity.
One last coffee, after having to replace bedroom air conditioner power socket.
Then it's time for a nap.

Roman · « **Reply #63 on:** 23 August 2011, 19:28 »

thanks for the files.....however...it does not crash here...
I've deleted several single profiles from your mess folder, nothing....I removed all...nothing....I removed the mess folder itself...nothing....
...and tried that several times...no issue

oxyandy · « **Reply #64 on:** 23 August 2011, 19:33 »

Oh, I had tried testing the crash on a different OS 'as is'

idea, one last thing to check..
quick reboot, I'll be back.

Roman · « **Reply #65 on:** 23 August 2011, 19:45 »

Coool......I got a crash
...but only under Windows XP (Virtual Machine)...not under Win7....

but now I should be able to fix that....

oxyandy · « **Reply #66 on:** 23 August 2011, 20:03 »

Alright this is another OS XP 64 SP2.
Still the same 32 cmp archive I sent.

it differs from the other 2 OS's I've tried this on,
cause the settings for Non-Unicode programs is English. (others this is Chinese)

I extracted the contents, and
tried Resetting some entries in the MESS folder, crashes still.
Tried deleting some, still crashes.

went to NonGood folder deleted an entry, crash again.
reset an entry in Nongood, again crash.

This is a very clean 'fresh' instal, I keep as an image.
It has no AV at all.
But also no malaware or any nasties, cause it's 'as new'
I don't have Win7 setup on these drives. So I can't try it... yet...

I'm not sure why I can repeat it so easy here and you cant.
Not sure what differences we have.
Maybe I could set-up some debugger, like visual studio has.. ?

oxyandy · « **Reply #67 on:** 23 August 2011, 20:07 »

Ok phew...
Our posts overlapped.. sounds good..
I'm not a 'nut' then

Hope you sort it out easy.

Roman · « **Reply #68 on:** 23 August 2011, 20:10 »

seems to be a weird one....since if it's a null pointer or wrong index it should crash everywhere...
wonder what the debugger will show....as soon as I've installed the development environment on the virtual machine....which takes some time...

Roman · « **Reply #69 on:** 23 August 2011, 22:04 »

argh...debug build on XP doesn't show any issue....smells like a compiler / optimizer issue...now that'll take some time to find that.....

oxyandy · « **Reply #70 on:** 24 August 2011, 02:16 »

Shame it's tricky.
I had hoped it would be easy for you.
So, on XP the crashes happen just like I describe here. ??
Win7, no crash..
Hmm

Roman · « **Reply #71 on:** 24 August 2011, 05:16 »

win7 no crash
winxp no crash when running debug or release from Visual Studio and on your files
winxp crash when running your exe on your files
winxp crash when running release compile on your files outside of Visual Studio

It seems to be related to a string class though...

oxyandy · « **Reply #72 on:** 24 August 2011, 06:22 »

Roman,
I hate to think you need to spend too much time on this crash, because the cause is the badly created dats..

I am really impressed that this new CMP can take dats 'as they are'..
Batch run them without any stops ( a first for me with this Unicode version )
Is usual painful hand editing before they will even load.

Like bad dats that use Unicode characters in the entries & author's name, yet are saved in ANSI.(sigh) The forum administrator of a group making these dats was informed much earlier this year, problem discussed, solutions suggested, yet nothing changed, cause the next dat release still contains the same exact badly formatted files.

If your program was only having to handle well made and formatted dats..
would it crash at this point at all ?

Roman · « **Reply #73 on:** 24 August 2011, 07:22 »

If the dats are structural no ok, cmpro won't load it...if it's just a bad character conversion it is loaded (however bad characters are shown then)...
I doubt that such dats cause a crash...

Roman · « **Reply #74 on:** 24 August 2011, 09:43 »

Looks like I've nailed it down...

never ever do pointer arithmetics when working with unicode :O)

oxyandy · « **Reply #75 on:** 24 August 2011, 10:10 »

Nice,
I went through the list, reset profiles, deleted
all from a fresh extract so it had everything jammed in there...
The crash is gone....

So it was a bug, you nailed it..

Now it seems invincible....

Is it final ?
We shall see..
I haven't finished trying to make it crash

Adv_AllowRestart = on

Let's take it for a test drive.

Roman · « **Reply #76 on:** 24 August 2011, 10:43 »

actually I'm not sure if it was an actual bug....

debugging the lines is fine, running them is fine (on Win7 always, on WinXP always when runned from the Visual Studio)...but a standalone release creates an issue with some Windows based libs......sounds more like a compiled code issue..

anyway, I rewrote the few lines and replaced some pointer arithmetics with basic function calls and it works....case closed.

oxyandy · « **Reply #77 on:** 24 August 2011, 11:04 »

Ok please do tell, it's great work,
how long did it take to resolve ?

It seems so solid now.
Not crashed

Roman · « **Reply #78 on:** 24 August 2011, 11:55 »

well...resolving was pretty fast...like 5 minutes..

I had an idea which part of the profile reader could be the cause for the fail after the debugger said something about the string class...
For the unicode build only that part had some weird LPTSTR casts here and there...so I rewrote that part and it worked...

oxyandy · « **Reply #79 on:** 24 August 2011, 12:41 »

That's a bit like me telling you I had an intermittent fault with my Plasma TV...
It only took me 1.5 minutes to fix (solder in a new part)
I wish... lol

I am done with 'testing', for now.
It's working really well now !

I may have a use for it later this evening.

I know what (bugs, glitches, errors, crashes) I found..
see.. being real careful on my word usage now.

I didn't test too hard after I found certain errors and reported them to you.
What did I miss, that others found ?

News:

Author Topic: Work In Progress (Read 50872 times)