EMULAB Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

The new forum is online, hope you enjoy it!

Pages: [1]   Go Down

Author Topic: Possible bug  (Read 11236 times)

Balthier

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Chrome 71.0.3578.98 Chrome 71.0.3578.98
    • View Profile
Possible bug
« on: 30 January 2019, 10:43 »

This may be a bug.  I noticed with the option "Remove Extension" checked when using Dir2Dat that game names with a dot in them get truncated in their <game name> and <description>.

For example:
   <game name="PC Engine Fan - Special CD-ROM^2 Vol. 1 (Japan)">
      <description>PC Engine Fan - Special CD-ROM^2 Vol. 1 (Japan)</description>
   <game name="Buster Bros. (Japan)">
      <description>Buster Bros. (Japan)</description>

becomes:
      <game name="PC Engine Fan - Special CD-ROM^2 Vol">
      <description>PC Engine Fan - Special CD-ROM^2 Vol</description>
   <game name="Buster Bros">
      <description>Buster Bros</description>

With that option unticked everything comes out correctly.  I'm using the nightly build.  Rom names are okay.

Also, are there any good modern guides that go into depth about the cmpro.ini file and the advanced and pro settings in it?  I figured out Adv_SetElementXML = machine when changed to "game" changes the <machine name> tag to <game name>.  Using google I just find old stuff.
Logged


Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3443
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 72.0.3626.81 Chrome 72.0.3626.81
    • View Profile
Re: Possible bug
« Reply #1 on: 30 January 2019, 13:15 »

Thanks for the headup regarding the extension.....guess it simply cuts everything after a "."
Of course it's hard to say what an extension is....for windows I guess you can assume one to maximum 4 characters...
but even that limit would crash "PC Engine Fan - Special CD-ROM^2 Vol. 1"
ok...you would say if there is a space after the ., ignore it, too....I will check if I can make it a bit more clever...but I guess there will be always some names which will fail.


Regarding newer guides about all the internal/hidden stuff....unfortunately not...usually I mention them in the history (https://mamedev.emulab.it/clrmamepro/#history) part when something useful is added or changed.
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3443
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 72.0.3626.81 Chrome 72.0.3626.81
    • View Profile
Re: Possible bug
« Reply #2 on: 30 January 2019, 20:26 »

ok..latest nightly build should do this more clever
Logged

Balthier

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Chrome 71.0.3578.98 Chrome 71.0.3578.98
    • View Profile
Re: Possible bug
« Reply #3 on: 31 January 2019, 03:00 »

Thanks for the headup regarding the extension.....guess it simply cuts everything after a "."
Of course it's hard to say what an extension is....for windows I guess you can assume one to maximum 4 characters...
but even that limit would crash "PC Engine Fan - Special CD-ROM^2 Vol. 1"
ok...you would say if there is a space after the ., ignore it, too....I will check if I can make it a bit more clever...but I guess there will be always some names which will fail.


Regarding newer guides about all the internal/hidden stuff....unfortunately not...usually I mention them in the history (https://mamedev.emulab.it/clrmamepro/#history) part when something useful is added or changed.
Yes I was thinking about this, perhaps something to tell the program to look at the name of a game, and if it contains "." or more than one "." then only remove everything after the last dot.  As for a guide I was just curious about the settings because I'm a power user when it comes to things, and I see a lot going on in the cmpro.ini that isn't evident in the UI :P  Thanks for the update I'll check it out in a little while.
Logged

Balthier

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Chrome 71.0.3578.98 Chrome 71.0.3578.98
    • View Profile
Re: Possible bug
« Reply #4 on: 31 January 2019, 05:07 »

Quick test and it seems to work well.  I tried to come up with a title containing many dots.

Code: [Select]
<game name="super duper bros. vs. lamer bros. vol. 1 - ep. 02">
<description>super duper bros. vs. lamer bros. vol. 1 - ep. 02</description>
<rom name="super duper bros. vs. lamer bros. vol. 1 - ep. 02.txt" size="4" crc="25cbfc4f" md5="37a6259cc0c1dae299a7866489dff0bd" sha1="2be88ca4242c76e8253ac62474851065032d6833"/>

quick edit- Forgot about the scene naming conventions with dots but that also works.
Code: [Select]
<game name="ULTRA.NEW.SCENE.RLS-MOCK.SCENERS">
<description>ULTRA.NEW.SCENE.RLS-MOCK.SCENERS</description>
<rom name="ULTRA.NEW.SCENE.RLS-MOCK.SCENERS.txt" size="4" crc="25cbfc4f" md5="37a6259cc0c1dae299a7866489dff0bd" sha1="2be88ca4242c76e8253ac62474851065032d6833"/>
« Last Edit: 31 January 2019, 05:19 by Balthier »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3443
  • Operating System:
  • Mac OS X Mac OS X
  • Browser:
  • Safari 10.0 Safari 10.0
    • View Profile
Re: Possible bug
« Reply #5 on: 31 January 2019, 05:32 »

what two lines of code can do :-)
Logged

Balthier

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Chrome 71.0.3578.98 Chrome 71.0.3578.98
    • View Profile
Re: Possible bug
« Reply #6 on: 31 January 2019, 07:29 »

what two lines of code can do :-)
Indeed. :)  And after all these years it still looks and functions the same as it always has.  No unnecessary bloat or ridiculous "features".  Gosh its been 20 years or something?  That's the mark of good software and programming.  Don't ever change that.
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3443
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 72.0.3626.81 Chrome 72.0.3626.81
    • View Profile
Re: Possible bug
« Reply #7 on: 31 January 2019, 08:24 »

It's 22 years this september...and no...it's old...it's ugly and bloated if you ask me ;-) An old horse trying to avoid the slaughterhouse
Logged

Balthier

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Chrome 72.0.3626.81 Chrome 72.0.3626.81
    • View Profile
Re: Possible bug
« Reply #8 on: 31 January 2019, 08:34 »

It's 22 years this september...and no...it's old...it's ugly and bloated if you ask me ;-) An old horse trying to avoid the slaughterhouse
LOL!  C'mon.  I trust this old horse as opposed to the other ones out there.  I did like Romcenter for a while but when it went to version 4 I tossed it in the garbage because it just didn't feel the same.  Tried RomVault and didn't like it, and I've read that it corrupts files sometimes and that's a deal breaker for me.
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 120
  • Offline Offline
  • Posts: 3443
  • Operating System:
  • Windows NT 10.0 Windows NT 10.0
  • Browser:
  • Chrome 72.0.3626.81 Chrome 72.0.3626.81
    • View Profile
Re: Possible bug
« Reply #9 on: 31 January 2019, 08:44 »

Ah well....corrupting files...I guess each tool has such rumors....There are endless out there about cmpro...not supporting this correctly...not handling that...blabla....People should use the correct forum (here) to post problems and I try my best to explain or fix it....if I find time, now with 46 and a family it's different than being a student and have time for coding nights...you see...tired old horse..not the program but me ;)
Logged
Pages: [1]   Go Up
 

Page created in 0.102 seconds with 26 queries.