Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[liaodahao]

Clrmamepro will ignore samples in "resource" field, is it a problem?
for example

Code: [Select]

resource (
    name nes_bandai_pt554
    description "NES Cart Bandai PT-554 PCB"
    sourcefile pt554.c
    sampleof ftaerobi
    sample 00
    sample 01
    sample 02
    sample 03
    sample 04
    sample 05
    sample 06
    sample 07
)
Clrmamepro won't scan the sample ftaerobi, just like it doesn't exist in the dat file.

[Roman]

well.....yeah I think 15 years ago there were no bios sets with samples around....will check it after my holiday....

[liaodahao]

It‘s not a dat file 15 years ago. It was generated by a tool recently, but the tool was made many yeas ago, so it output the dat file in old format.
Have a good holiday!

[Roman]

well...but the old datfile format is deprecated since then ;-) ok...11 years....(MAME .84)....I will look into the samples stuff later...

[Roman]

well....I had a quick look...there is no sample support for bios sets at all ;-)
since it's not yet used in MAME and due to lack of time I put it on the to-do list....but don't expect it too soon

[liaodahao]

there is no sample support for bios sets at all

What doesn't support it? clrmame or old datfile format?
The new datfile format can support it, I've already tested this.

since it's not yet used in MAME

But I think MAME has used it already. Here is part of the MAME 0.162 XML output:

Code: [Select]

<machine name="nes_bandai_pt554" sourcefile="src/emu/bus/nes/pt554.c" isdevice="yes" runnable="no" sampleof="ftaerobi">
<description>NES Cart Bandai PT-554 PCB</description>
<sample name="00"/>
<sample name="01"/>
<sample name="02"/>
<sample name="03"/>
<sample name="04"/>
<sample name="05"/>
<sample name="06"/>
<sample name="07"/>
<chip type="audio" tag=":addon" name="Speaker"/>
<chip type="audio" tag=":samples" name="Samples"/>
<sound channels="1"/>
</machine>Do you mean although MAME lists bios sets with samples in the XML output, it hasn't use these samples yet?

I put it on the to-do list....but don't expect it too soon

Thank you. As you said, the old datfile format is deprecated, so it's not urgent.

[Roman]

that's a device, not a bios....that should work fine already...adding support for bios shouldn't be too tough....maybe I was too lazy yesterday...

[liaodahao]

I'm sorry. I thought runnable="no" means it's a bios...
The code I posted at the beginning of this thread is actually converted from the code at #5. It seems that there is no such a "device" definition in old datfile format, so you're right, the old format should be deprecated.

[Roman]

there is an attribute isBios if I'm not mistaken....which identifies bios sets....
and you're right...there is nothing like a device specification in the deprecated format...they will be standard sets....(not 'resources')

[liaodahao]

About the bios sets with samples, I found another one:

Code: [Select]

<machine name="allied" sourcefile="allied.c" isbios="yes" sampleof="genpin">
<description>Allied System</description>
<year>1977</year>
<manufacturer>Allied Leisure</manufacturer>
<rom name="6530-009.u5" size="1024" crc="e4fb64fb" sha1="a3d9de7cbfb42180a860e0bbbeaeba96d8bd1e20" region="maincpu" offset="1400"/>
<rom name="6530-010.u6" size="1024" crc="dca980dd" sha1="3817d75413854d889fc1ce4fd6a51d820d1e0534" region="maincpu" offset="1800"/>
<rom name="6530-011.u3" size="1024" crc="13f42789" sha1="baa0f73fda08a3c5d6f1423fb329e4febb07ef97" region="maincpu" offset="1c00"/>
<device_ref name="m6504"/>
<device_ref name="speaker"/>
<device_ref name="samples"/>
<device_ref name="pia6821"/>
<device_ref name="pia6821"/>
<device_ref name="pia6821"/>
<device_ref name="pia6821"/>
<device_ref name="pia6821"/>
<device_ref name="mos6530"/>
<device_ref name="mos6530"/>
<device_ref name="mos6530"/>
<device_ref name="timer"/>
<sample name="bumper"/>
<sample name="chime1"/>
<sample name="chime2"/>
<sample name="chime3"/>
<sample name="chime4"/>
<sample name="hole"/>
<sample name="knocker"/>
<sample name="sling"/>
<sample name="coinin"/>
<chip type="cpu" tag="maincpu" name="M6504" clock="893137"/>
<chip type="audio" tag="mechvol" name="Speaker"/>
<chip type="audio" tag="samples" name="Samples"/>
<sound channels="1"/>
                .....
</machine>clrmame won't scan the samples in bios set, but if I scan it through using the whole datfile, I won't find any error, becasue there are other places of the datfile have code like this:

Code: [Select]

<machine name="mbossy" sourcefile="gp_2.c" ismechanical="yes" sampleof="genpin">
<description>Mike Bossy</description>
<year>1982</year>
<manufacturer>Game Plan</manufacturer>
<rom name="mb_a.716" size="2048" status="nodump" region="roms" offset="0"/>
<rom name="mb_b.716" size="2048" status="nodump" region="roms" offset="800"/>
<rom name="mb_c.716" size="2048" status="nodump" region="roms" offset="1000"/>
<rom name="mb.u9" size="2048" crc="dfa98db5" sha1="65361630f530383e67837c428050bcdb15373c0b" region="cpu2" offset="3800"/>
<rom name="mb.u10" size="2048" crc="2d3c91f9" sha1="7e1f067af29d9e484da234382d7dc821ca07b6c4" region="cpu2" offset="3000"/>
<device_ref name="z80"/>
<device_ref name="nvram"/>
<device_ref name="speaker"/>
<device_ref name="samples"/>
<device_ref name="i8255"/>
<device_ref name="z80ctc"/>
<device_ref name="timer"/>
<sample name="bumper"/>
<sample name="chime1"/>
<sample name="chime2"/>
<sample name="chime3"/>
<sample name="chime4"/>
<sample name="hole"/>
<sample name="knocker"/>
<sample name="sling"/>
<sample name="coinin"/>
<chip type="cpu" tag="maincpu" name="Z80" clock="2457600"/>
<chip type="audio" tag="mechvol" name="Speaker"/>
<chip type="audio" tag="samples" name="Samples"/>
<sound channels="1"/>
                .....
</machine>clrmame will scan the same samples in non bios sets, so I won't see any error.

[Roman]

well..it (as some other hundred sets) uses the samples of "genpin" which is a (sampleonly) set...and that genpin set is verified, too...so auditing wise it's fine...
for completeness however I should add support though

[Roman]

ok...it's in for next version