EMULAB Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

The new forum is online, hope you enjoy it!

Pages: 1 [2]   Go Down

Author Topic: wrong error "double name" in datfile loading  (Read 16551 times)

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 43.0.2357.130 Chrome 43.0.2357.130
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #20 on: 22 June 2015, 18:51 »

ok...found the reason why the "double name warning" causes a bit trouble...

You may want to try this:

http://mamedev.emulab.it/clrmamepro/binaries/cmp20150622.rar
Logged

pucci

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 44
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 38.0 Firefox 38.0
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #21 on: 22 June 2015, 20:11 »

Don't get me wrong, I highly appreciate your effort in testing this regional thing (which can be indeed confusing, especially when merging is also taken into account).

I am proud to help the development of ClrMAME Pro

ClrMAME use it since he was a program without a GUI that was used from the command line

When ClrMAME (but not yet called "Pro") had his first graphical interface consists of a single page, i asked you to add scan statistics
You added scan statistics, and replied to me giving me the name "lazy user" :)
My name was also in the "thanks to" section of the readme.txt

By the way: is there any way to recover those old versions?
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Mac OS X Mac OS X
  • Browser:
  • Safari 8.0 Safari 8.0
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #22 on: 22 June 2015, 20:19 »

well....from clrmame and cmwin I only got the sources of the most latest version....wonder if I can still compile them....but generally they are not really of any use....:-)
« Last Edit: 22 June 2015, 20:19 by Roman »
Logged

pucci

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 44
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 38.0 Firefox 38.0
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #23 on: 22 June 2015, 20:21 »

ok...found the reason why the "double name warning" causes a bit trouble...

You may want to try this:

http://mamedev.emulab.it/clrmamepro/binaries/cmp20150622.rar

i have made some test (different scan with different regions order) and not this problem seem gone:

Quote
i checked my roms 2 times with Nintendo64 No-Intro dat and 1G1R option selected
The 2 test uses same regions order

The result of the two test is different (in some case the "chosing" algoritm select Eur instead of USA)

The 2 test i have done uses the same option, i don't have touched any selection but result are not the same

This thing is very strange and i think that ClrMAME have some sort of "state variabile" that remember previous action

Is not simple for me to explain, but i'm sure that there's some hidden bugs in Regions routine

now remain only the problem of double names
can we see the regions selection algorithm?
« Last Edit: 22 June 2015, 20:22 by pucci »
Logged

pucci

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 44
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 38.0 Firefox 38.0
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #24 on: 22 June 2015, 20:23 »

well....from clrmame and cmwin I only got the sources of the most latest version....wonder if I can still compile them....but generally they are not really of any use....:-)

no use, but great historical value
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Mac OS X Mac OS X
  • Browser:
  • Safari 8.0 Safari 8.0
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #25 on: 22 June 2015, 20:26 »

good to hear the reorganize and scan crash are gone....regarding the algorithm....sure...I can post it......either later tonight or tomorrow
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 43.0.2357.130 Chrome 43.0.2357.130
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #26 on: 22 June 2015, 21:42 »

well...after checking old emails from 2008 I tried to understand again what this region thing was all about...

basically it's a "prefered" name for the parent set when you fully merge sets. "prefered" based on your region/language selection...so for example as an user from Europe you may prefer the europe's version name of a game, as an user from Japan, you want to use the Japanese name maybe even in Japanese characters...

now in our litte USA/EUR/JAP example you end up with a warning regarding the USA set...the reason is simple: the parent (actually the Europe set) gets the prefered USA naming and the actually USA clone now got the problem that it uses the exact same name...

- clrmame needs identical setnames internally (well unique setnames within a software list to be more concrete...)
- you don't really need to care about the renamed clone set since this only happens when you fully merge sets...and then the parent set name is the interesting one...and in our example this is the wanted USA name..

so you end up with a zip/rar/7z/folder named "NBA in the Zone '98 (USA)" which holds the single files: "NBA Pro 98 (Europe).n64", "NBA in the Zone '98 (Japan).n64" and "NBA in the Zone '98 (USA).n64"

I guess the open question is if the warning prompt should be visible to the user at all...the need of the rename to have unique preferable names is more a cmpro internal thing...and besides of the scanner's set-info dialog you won't see the "*USA_0" name at all....
So actually I think I will hide the prompt and do the rename internally....
« Last Edit: 22 June 2015, 22:01 by Roman »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 43.0.2357.130 Chrome 43.0.2357.130
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #27 on: 22 June 2015, 21:55 »

just for completeness, the pseudo algorithm:

getThePreferedName of a PARENT set:

int bestScore = 0;

for parent set and all its clones do {
  for each release in current set do {
    int score = 0;
    if (release got region and region is in active_prio_ordered_region_array) {
      score += size of region_array - position in region_array;
    }
    score *= size of language_array + 1;

    if (release got language and language is in active_prio_ordered_language_array) {
      score += size of language_array - position in language_array;
    }
    score *= 2;

    if (release got defaultFlag) {
      score += 1;
    }

    score *= 2;

    if (current set is parent set) {
      score += 1;
    }

    if (score > bestScore) {
      preferedName = name of current set;
      bestscore = score;
    }
  }
}
« Last Edit: 22 June 2015, 22:03 by Roman »
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Mac OS X Mac OS X
  • Browser:
  • Safari 8.0 Safari 8.0
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #28 on: 22 June 2015, 22:17 »

and even more...I do remember why the double name check came in...there was a case/datfile/region combination where you get double parent names...which is of course evil and needs to be resolved by a rename.

sooo...the double name check and prompt needs to be shown and used if you got double names for parents...and I guess I can hide (or maybe even remove it) if clones are affected.
« Last Edit: 22 June 2015, 22:18 by Roman »
Logged

pucci

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 44
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 38.0 Firefox 38.0
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #29 on: 04 July 2015, 11:36 »

so you end up with a zip/rar/7z/folder named "NBA in the Zone '98 (USA)" which holds the single files: "NBA Pro 98 (Europe).n64", "NBA in the Zone '98 (Japan).n64" and "NBA in the Zone '98 (USA).n64"

you must add a great feature:
a checkbox "remove region tag"
il checkbox is selected, in the example above whe have
a zip/rar/7z/folder named "NBA in the Zone '98"
which holds the single files
- "NBA Pro 98 (Europe).n64"
- "NBA in the Zone '98 (Japan).n64"
- "NBA in the Zone '98 (USA).n64

if is also selected 1G1R the result will be
a zip/rar/7z/folder named "NBA in the Zone '98" which holds the file "NBA in the Zone '98 (USA).n64"

I guess the open question is if the warning prompt should be visible to the user at all...the need of the rename to have unique preferable names is more a cmpro internal thing...and besides of the scanner's set-info dialog you won't see the "*USA_0" name at all....
So actually I think I will hide the prompt and do the rename internally....

please remove the warning or add a checkbox to hide the warning
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 43.0.2357.130 Chrome 43.0.2357.130
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #30 on: 04 July 2015, 12:07 »

the warning is already gone in my latest build...and actually there was some additional work on the whole topic done....

I don't see the sense in another checkbox...where is the difference to simply untick all regions in the settings box?
Logged

pucci

  • Member
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 44
  • Operating System:
  • Windows NT 6.3 Windows NT 6.3
  • Browser:
  • Firefox 38.0 Firefox 38.0
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #31 on: 04 July 2015, 13:53 »

I don't see the sense in another checkbox...where is the difference to simply untick all regions in the settings box?

if checkbox "remove region tag" is checked and "normal mode"
a zip/rar/7z/folder named "NBA in the Zone '98"
which holds the single files
- "NBA Pro 98 (Europe).n64"
- "NBA in the Zone '98 (Japan).n64"
- "NBA in the Zone '98 (USA).n64

if checkbox "remove region tag" is checked and "1G1R mode"
a zip/rar/7z/folder named "NBA in the Zone '98" which holds the file "NBA in the Zone '98 (USA).n64"

if checkbox "remove region tag" is UNchecked and "normal mode"
a zip/rar/7z/folder named "NBA in the Zone '98 (USA)"
which holds the single files
- "NBA Pro 98 (Europe).n64"
- "NBA in the Zone '98 (Japan).n64"
- "NBA in the Zone '98 (USA).n64

if checkbox "remove region tag" is UNchecked and "1G1R mode"
a zip/rar/7z/folder named "NBA in the Zone '98 (USA)" which holds the file "NBA in the Zone '98 (USA).n64"
Logged

Roman

  • Global Moderator
  • Member
  • ***
  • Karma: 113
  • Offline Offline
  • Posts: 3292
  • Operating System:
  • Windows 7/Server 2008 R2 Windows 7/Server 2008 R2
  • Browser:
  • Chrome 43.0.2357.130 Chrome 43.0.2357.130
    • View Profile
Re: wrong error "double name" in datfile loading
« Reply #32 on: 04 July 2015, 18:08 »

How should cmpro decide that the setname is "NBA in the Zone '98" in your first example. There is no such reference in the datfile at all. There is "NBA in the Zone '98 (Japan)", ""NBA in the Zone '98 (USA)" and "NBA in the Zone '98 (Europe)". Thinking that you got a region USA then I can remove (USA) from the title is wrong. That's wild guessing, nothing else. It fails directly for "EUR" vs "(Europe)" etc...
Another option to make the region stuff even more complex is not on my to do list....
Logged
Pages: 1 [2]   Go Up
 

Page created in 0.176 seconds with 19 queries.

anything
anything