Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[KingTut]

Source: http://git.redump.net/mame/commit/hash?id=bc221ccf56d54239d7e4b0bd9aab2275417c5bbe

New amiga_a3000.xml softlist is causing problems.
Direct Link: http://git.redump.net/mame/plain/hash/amiga_a3000.xml

Problem: Clrmamepro is constantly adding/deleting/re-adding cass ROM file when a new scan is performed.

amiga_a3000.xml

Code: [Select]

<?xml version="1.0"?>
<!DOCTYPE softwarelist SYSTEM "softwarelist.dtd">

<!-- This list contains the system software specific to the Amiga 3000: -->
<!-- SuperKickstart disks, SCSI installation disks and AMIX -->

<softwarelist name="amiga_a3000" description="Amiga 3000 System disks">

<!-- SuperKickstart -->

<software name="sk201">
<description>Kickstart 2.01</description>
<year>1990</year>
<publisher>Commodore</publisher>
<part name="flop1" interface="floppy_3_5">
<feature name="part_id" value="Kickstart 2.01" />
<dataarea name="flop" size="901120">
<rom name="367245-03_kickstart.adf" size="901120" crc="79c58ce8" sha1="8e738fb5a9d293c8321cf5055c06f368d43a6e2b" offset="0"/>
</dataarea>
</part>
</software>

<software name="sk204">
<description>Kickstart 2.04</description>
<year>1991</year>
<publisher>Commodore</publisher>
<part name="flop1" interface="floppy_3_5">
<feature name="part_id" value="Kickstart 2.04" />
<dataarea name="flop" size="901120">
<rom name="367245-06_kickstart.adf" size="901120" crc="87ad0c5b" sha1="922ec2776766a6568f3e2de37101c497067948e4" offset="0"/>
</dataarea>
</part>
</software>

<!-- A3000 Installation disks -->

<software name="a3kin203">
<description>A3000 Install Disk 2.03</description>
<year>1991</year>
<publisher>Commodore</publisher>
<part name="flop1" interface="floppy_3_5">
<feature name="part_id" value="A3000 Install Disk 2.03" />
<dataarea name="flop" size="901120">
<rom name="335603-04_install.adf" size="901120" crc="9a3cc466" sha1="b12a225890a3957bb01dcbfba44c046c19e19c8f" offset="0"/>
</dataarea>
</part>
</software>

<!-- Amiga UNIX System V Release 4 -->
<!-- TODO: Part numbers -->

<software name="amix11">
<description>UNIX System V Release 4 Amiga Version 1.1</description>
<year>1990</year>
<publisher>Commodore</publisher>
<part name="flop1" interface="floppy_3_5">
<feature name="part_id" value="Installation Disk 1 (Boot)"/>
<dataarea name="flop" size="901120">
<rom name="amix_11_boot.adf" size="901120" crc="83a9c798" sha1="7b530cb8ff39933c7cef2ee6349a9b2d147e6a6d" offset="0" />
</dataarea>
</part>
<part name="flop2" interface="floppy_3_5">
<feature name="part_id" value="Installation Disk 2 (Root file system)"/>
<dataarea name="flop" size="901120">
<rom name="amix_11_root.adf" size="901120" crc="9ac8c76e" sha1="61f06cf47c12930ff9677c57a8464c549c5fb839" offset="0" />
</dataarea>
</part>
<part name="tape" interface="a3000_cass">
<feature name="part_id" value="Installation Tape"/>
<dataarea name="cass" size="0">
<rom name="cass" size="0" status="nodump" offset="0" />
</dataarea>
</part>
</software>

<software name="amix201" cloneof="amix11">
<description>UNIX System V Release 4 Amiga Version 2.01</description>
<year>199?</year>
<publisher>Commodore</publisher>
<part name="flop1" interface="floppy_3_5">
<feature name="part_id" value="Installation Disk 1 (Boot)"/>
<dataarea name="flop" size="901120">
<rom name="amix_201_boot.adf" size="901120" crc="7e3ecc6b" sha1="63d0144296e63b8ea09e4c1b2a85d1e09dc111e5" offset="0" />
</dataarea>
</part>
<part name="flop2" interface="floppy_3_5">
<feature name="part_id" value="Installation Disk 2 (Root file system)"/>
<dataarea name="flop" size="901120">
<rom name="amix_201_root.adf" size="901120" crc="c8fef4fd" sha1="840a23a93329b4f68113515f9bf466bb15af1bc7" offset="0" />
</dataarea>
</part>
<part name="tape" interface="a3000_cass">
<feature name="part_id" value="Installation Tape"/>
<dataarea name="cass" size="0">
<rom name="cass" size="0" status="nodump" offset="0" />
</dataarea>
</part>
</software>

<software name="amix203" cloneof="amix11">
<description>UNIX System V Release 4 Amiga Version 2.03</description>
<year>199?</year>
<publisher>Commodore</publisher>
<part name="flop1" interface="floppy_3_5">
<feature name="part_id" value="Installation Disk 1 (Boot)"/>
<dataarea name="flop" size="901120">
<rom name="amix_203_boot.adf" size="901120" crc="a10249c1" sha1="5c62519528d92a6e8a7b88d9879d9d0903e90ad2" offset="0" />
</dataarea>
</part>
<part name="flop2" interface="floppy_3_5">
<feature name="part_id" value="Installation Disk 2 (Root file system)"/>
<dataarea name="flop" size="901120">
<rom name="amix_203_root.adf" size="901120" crc="6859ae85" sha1="ed38709d4f9b7a1cfc42112038e74b75587de73f" offset="0" />
</dataarea>
</part>
<part name="tape" interface="a3000_cass">
<feature name="part_id" value="Installation Tape"/>
<dataarea name="cass" size="0">
<rom name="cass" size="0" status="nodump" offset="0" />
</dataarea>
</part>
</software>

<software name="amix21" cloneof="amix11">
<description>UNIX System V Release 4 Amiga Version 2.1</description>
<year>199?</year>
<publisher>Commodore</publisher>
<part name="flop1" interface="floppy_3_5">
<feature name="part_id" value="Installation Disk 1 (Boot)"/>
<dataarea name="flop" size="901120">
<rom name="amix_21_boot.adf" size="901120" crc="99a92138" sha1="c3c444fdf00275b8a1d57d3da8556267977d940a" offset="0" />
</dataarea>
</part>
<part name="flop2" interface="floppy_3_5">
<feature name="part_id" value="Installation Disk 2 (Root file system)"/>
<dataarea name="flop" size="901120">
<rom name="amix_21_root.adf" size="901120" crc="7c134fcd" sha1="586cba2c40e007d09f634647e15e33a5ac4ba069" offset="0" />
</dataarea>
</part>
<part name="flop3" interface="floppy_3_5">
<feature name="part_id" value="Patch Disk"/>
<dataarea name="flop" size="901120">
<rom name="amix_patch_21.adf" size="901120" crc="6b401165" sha1="325df79e3ca52709d47512227d187c87ed4c9472" offset="0" />
</dataarea>
</part>
<part name="tape" interface="a3000_cass">
<feature name="part_id" value="Installation Tape"/>
<dataarea name="cass" size="0">
<rom name="cass" size="0" status="nodump" offset="0" />
</dataarea>
</part>
</software>

</softwarelist>
After looking over the amiga_a3000 softlist, I noticed this ROM file has a "nodump" status.

Code: [Select]

rom name="cass" size="0" status="nodump" offset="0" />
This ROM appears under the software name amix11, amix201, amix203 and amix21.

Solution: The only way to alleviate the problem is by changing the size of the ROM to another number besides 0.

Code: [Select]

rom name="cass" size="1" status="nodump" offset="0" />
Clrmamepro no longer has the need to constantly re-add/delete cass ROM file.

I'm including the softlist in the attachment below, in case something changes with the SVN link that was pointed out at the beginning of the post.

[KingTut]

I would also like to add, this may have been done intentionally. Data area of this ROM, shows the size being zero as well.

Code: [Select]

<dataarea name="cass" size="0">
Guess this is something that needs to fixed on your end?

[Roman]

hmm..actually nodumps should be ignored totally....have to check that...

[Roman]

ah...it's not detected as a nodump rom....guess that can be easily fixed.

[KingTut]

Great.

[Roman]

well...I looked a bit closer....and actually nodump with a given size == 0  is reset to a good dump (with size = 0)....
Fix missing can create this file...but should not mark it directly as unneded....maybe it's not really added? (maybe you're using 7z or something)
Can you 7zip up your romset for me please?

[KingTut]

I'm not using 7zip to archive my sets. I'm using plain ole' ZIP format.

I changed the ROM set to use 7zip instead of ZIP like you asked me to. Same result.

I'm going to include the amiga_a3000 full ROM set for you to test out. See link below.

amiga_a3000.7z (5.38 MB)
http://www6.zippyshare.com/v/73236024/file.html

I've excluded the cass ROM file from 4 of the ROM sets (amix11, amix201, amix203 and amix21) so you can get a better understanding what's going on.

For the first test, make sure split mode is used for these ROM sets. Run new scan. These messages will appear soon after.

1st New Scan (Split)

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 1.1
Name: amix11
File: I:\MESS\software\amiga_a3000\amix11\cass

Do you want to add the missing ROM?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.01
Name: amix201
File: I:\MESS\software\amiga_a3000\amix201\cass

Do you want to add the missing ROM?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.03
Name: amix203
File: I:\MESS\software\amiga_a3000\amix203\cass

Do you want to add the missing ROM?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.1
Name: amix21
File: I:\MESS\software\amiga_a3000\amix21\cass

Do you want to add the missing ROM?
YES

cass ROMs (dummy files) were added to the following four sets (as mentioned above) with the file size being zero and the CRC being 0000000 as listed in the archives. ROM set complete with nothing to fix.

Now perform a second new scan. The following messages will appear soon after.

2nd New Scan (Split)

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.01
Name: amix201
File: I:\MESS\software\amiga_a3000\amix201\cass

Do you want to remove the file?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.03
Name: amix203
File: I:\MESS\software\amiga_a3000\amix203\cass

Do you want to remove the file?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.1
Name: amix21
File: I:\MESS\software\amiga_a3000\amix21\cass

Do you want to remove the file?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.01
Name: amix201
File: I:\MESS\software\amiga_a3000\amix201\cass

Do you want to add the missing ROM?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.01
Name: amix201
File: I:\MESS\software\amiga_a3000\amix201\cass

Do you want to remove the file?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.03
Name: amix203
File: I:\MESS\software\amiga_a3000\amix203\cass

Do you want to add the missing ROM?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.03
Name: amix203
File: I:\MESS\software\amiga_a3000\amix203\cass

Do you want to remove the file?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.1
Name: amix21
File: I:\MESS\software\amiga_a3000\amix21\cass

Do you want to add the missing ROM?
YES

Code: [Select]

Set: UNIX System V Release 4 Amiga Version 2.1
Name: amix21
File: I:\MESS\software\amiga_a3000\amix21\cass

Do you want to remove the file?
YES

If I had chosen to keep the cass ROM file instead of removing them, clrmamepro will now show the cass ROM file as being unneeded for amix201, amix203 and  amix21 set. Strange how clrmamepro doesn't mark cass ROM file as unneeded for amix11 set.

For the second test, I used merge mode instead of split mode (without the cass ROM file), clrmamepro will add the cass ROM file to amix11 set only (amix201, amix203 and amix21 clone set is now consolidated into amix11 parent). Performing a second new scan, nothing needs to be fixed.

Is this parent/clone bug in clrmamepro?

[KingTut]

Come to think of it, you maybe dealing with two different issues.

As a test, I've created two different DAT files for you to try out. Both DATs contains one ROM entry with a "no dump" status set. One DAT has a file size of 0 byte and the other DAT with a file size of 1 byte. Readme included with DATs. See attachment below.

As for the second issue, not sure about that one. That may or may not be related to the first issue. Guess that's something you need to explore?

[Roman]

Well, the 0 byte file is added to each set because the "belongs-to-parent-check" is checksum based...guess there is the problem....not the nodump thingie..
as mentioned, a nodump with a given size = 0 becomes a valid dump with size = 0...

when I'm back home later I can double check...

I only tried the parent set...and it correctly added it once...and did not want to remove it...
with clones, I got an idea where the problem is...bet 'there' it sees that the clone files are not needed since they are in the parent already....

as I said...funny scenario...will work on it later tonight

[Roman]

ok...the parent/clone relationship is now correctly detected for such zero byte files...problem solved with next release...

[KingTut]

Well, the 0 byte file is added to each set because the "belongs-to-parent-check" is checksum based...guess there is the problem....not the nodump thingie..
as mentioned, a nodump with a given size = 0 becomes a valid dump with size = 0...

when I'm back home later I can double check...

I only tried the parent set...and it correctly added it once...and did not want to remove it...
with clones, I got an idea where the problem is...bet 'there' it sees that the clone files are not needed since they are in the parent already....

as I said...funny scenario...will work on it later tonight

Kinda hard to believe when you can create dummy ROM in a set by using file size of zero and inserting CRC 00000000 in a DAT, which would do the exact same thing.

Code: [Select]

<rom name="dummy" size="0" crc="0000000"/>
That's how I've seen it done in other DAT files.

Never knew you can do it the way MESS did it. I thought that was a bug in clrmamepro, even though you've already stated twice to me that it wasn't the case. Sorry for being so thick headed. I was confused.

ok...the parent/clone relationship is now correctly detected for such zero byte files...problem solved with next release...

Glade the real problem has been solved.

[Roman]

There is a special marking procedure which says a given size of "0" (not "-" or not specified, which also exist) is a valid rom and no nodump. Don't ask me where in the 17 years of cmpro this comes from...

....and there is a marking procedure which marks a rom in a clone set as being-a-rom-from-its-parent. And that one had a problem with such 0-size roms...
...all the rest of your problems was simply based on that wrong marking