Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

I mean just a current non delta regular clone CHD that's marked bad dump.  With your wise XML ways do you see one or a few?

I haven't spent any time on convertig chds to deltas...so..nope..

Thanks, do you know of another 'bad' flagged clone CHD I can check to see if it's the bad flag or if it seems specific to these huge python2.cpp games (DVDs I think).

well....haven't looked into detail yet but in general cmpro only reads the chd header and compares the hashes....a decompression error can only be found if Scanner-Hash&CHD-CHD MD5/SHA1+Decompress CHD & check SHA1/MD5 is checked.
So that is most likely the reason why cmpro doesn't come up with a warning by default...the header of the bad file seems to be valid.

Seems to me another chdman issue regarding delta chds.....one where the creation doesn't exit with an error message but the produced data is bad.

Been looking at this for a couple of days brought on by an audit in the MAME UI (F1) and the available filter.  Shows 14 damaged delta CHDs that can't be -verify or -info'ed with chdman. Before I posted at mametesters I was hoping for a confirmation here, note that clrmame doesn't flag these w/ default settings.  Possible commonality? CHDs marked as 'Bad Dump'.

Current tip of tree chdman.exe (or release .262) is producing some delta chds that will error on run with 'CHD ERROR: Decompression error'. Resulting in machine placement into unavailable filter folder in MAME UI.

One such example is the child/clone photoply_sprt_xt_2004_sp_u.chd in Photo Play Spirit Xtreme (Spanish) / photopsxsp

Steps to repro:
1. Use full merged storage method.
2. Place the two Photo Play Spirit Xtreme (Spanish) CHDs into their appropriate directory:
"C:\MAME\Roms\photopsxsp\photoply_sprt_xt_2004_sp_u.chd"
"C:\MAME\Roms\photopsxsp\photoply_sprt_xt_2004_sp.chd"

7,283,106,173 photoply_sprt_xt_2004_sp.chd
3,427,733,716 photoply_sprt_xt_2004_sp_u.chd

3. Launch MAME.exe and do an audit with F1 from the UI.
4. Confirm Photo Play Spirit Xtreme (Spanish) is not present in the Unavailable filter/folder.
5. Convert the child CHD to a delta w/ clrmamepro or manually.
6. New child CHD gets cut down to size to:

1,977,511,281 photoply_sprt_xt_2004_sp_u.chd

7. Attempt to verify this chd:
\MAME\ROMs\photopsxsp>chdman verify -i photoply_sprt_xt_2004_sp_u.chd -ip photoply_sprt_xt_2004_sp.chd
chdman - MAME Compressed Hunks of Data (CHD) manager 0.262 (mame0262-152-g0636e54bb60)
Error opening CHD file (photoply_sprt_xt_2004_sp_u.chd): Decompression error
Fatal error occurred: 1

8. Run audit in MAME's UI with F1.
9. Observe Photo Play is now in the unavailable filter/folder due to the error.
10. A normal run with clrmamepro does not find this.


---
c:\O\Games\MAME\ROMs\photopsxsp>chdman info -v -i photoply_sprt_xt_2004_sp_u.chd
chdman - MAME Compressed Hunks of Data (CHD) manager 0.262 (mame0262-152-g0636e54bb60)
Error opening CHD file (photoply_sprt_xt_2004_sp_u.chd): Decompression error
Fatal error occurred: 1

Before delta creation, child CHD is ok:
c:\Users\jhard\Desktop\ROMs\MAME 0.262 CHDs (merged)\photopsxsp>chdman info -i photoply_sprt_xt_2004_sp_u.chd
chdman - MAME Compressed Hunks of Data (CHD) manager 0.262 (mame0262)
Input file:   photoply_sprt_xt_2004_sp_u.chd
File Version: 5
Logical size: 160,041,885,696 bytes
Hunk Size:    4,096 bytes
Total Hunks:  39,072,726
Unit Size:    512 bytes
Total Units:  312,581,808
Compression:  lzma (LZMA), zlib (Deflate), huff (Huffman), flac (FLAC)
CHD size:     3,427,733,716 bytes
Ratio:        2.1%
SHA1:         dac230cae6efaa24362260101d39b421d5fccd45
Data SHA1:    5c60dcfee2c635e4c20fa733aad37c60c003b600
Metadata:     Tag='GDDD'  Index=0  Length=37 bytes
              CYLS:310101,HEADS:16,SECS:63,BPS:512.

c:\Users\jhard\Desktop\ROMs\MAME 0.262 CHDs (merged)\photopsxsp>chdman verify -i photoply_sprt_xt_2004_sp_u.ch
chdman - MAME Compressed Hunks of Data (CHD) manager 0.262 (mame0262)
Raw SHA1 verification successful!
Overall SHA1 verification successful!

Actual delta CHD creation goes through 100%:
c:\O\Games\MAME\ROMs\photopsxsp>chdman copy -i photoply_sprt_xt_2004_sp_u.chd -op photoply_sprt_xt_2004_sp.chd -o newchild.chd
chdman - MAME Compressed Hunks of Data (CHD) manager 0.262 (mame0262)
Output CHD:   newchild.chd
Parent CHD:   photoply_sprt_xt_2004_sp.chd
Input CHD:    photoply_sprt_xt_2004_sp_u.chd
Compression:  lzma (LZMA), zlib (Deflate), huff (Huffman), flac (FLAC)
Hunk size:    4,096
Logical size: 160,041,885,696
Compression complete ... final ratio = 1.2%

02/22/2024  12:18 PM     1,977,511,281 newchild.chd

Info and verify of new delta CHD fails and goes to unavailable upon audit.
c:\O\Games\MAME\ROMs\photopsxsp>chdman info -i newchild.chd
chdman - MAME Compressed Hunks of Data (CHD) manager 0.262 (mame0262)
Error opening CHD file (newchild.chd): Decompression error
Fatal error occurred: 1

You need to use https://mamedev.emulab.it/clrmamepro/binaries/cmpro_deltaverify.7z
which is rock stable
Real life job currently takes all my time.....

Well yes, since cmpro does a "chdman verify -i %1" command which would fail on deltas....it would require "chdman verify -i %1 -ip %2" where %2 gets replaced with the parent chd filename...but that's currently not supported (but on the to do list).
So...for delta the deep check won't work....but as I said: currently nobody is using delta chds since there are some open issues with them on chdman side, see https://github.com/mamedev/mame/issues/11675

Hi Roman, in the course of investigating some of the malformed delta chd creations, I tried to use cmpro to do validity checks on my existing chds and hit this problem above w/ a new commandline param needed for delta chd verification.  Is that feature mature enough to release into a full build at this point?  Thanks -

Latest 7-Zip beta does have included zstandard compression method.

Full merged, split merged and standalone will be the future. Nothing else, but of course you can achieve any possible combination by using modified datfiles.

Oh, that's interesting! I wasn't aware of that. I understand the concept of a "standalone" set, which creates a non-merged set including everything, such as BIOS and devices. However, I'm curious if there are plans to offer more flexibility in the future. For instance, I prefer having a split set with separate BIOS files but not separate device(s). Take my supermodel3 emulator, for example. It's itching for a split ROM set with devices included. Sure, I could roll up my sleeves and do it manually, but where's the fun in that? Let's automate the spice!