EMULAB Forum

clrmamepro [English] => clrmame Discussion => Topic started by: newuzer on 28 March 2022, 09:10

Title: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: newuzer on 28 March 2022, 09:10
Hi Roman,

Rebuilding the 0.241 pc8801_flop set with the pc8801_flop 0.242 XML ends up in losing a ROM.
Attached both sets in 0.241 configuration and the stripped 0.242 XML to reproduce.
The 2 ROMs are being swapped between these sets.
Scan/fix the 2 sets will result in an attempt to resize, remove and and adding the missing ROM.
You would expect the ROMs to be placed in and being able to rebuilt from backup.
However 1 ROM has disappeared, even when you choose not to resize.
Rebuilding from a copy of the 2 sets results in 0 missings.

With kind regards, NU.
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: Roman on 28 March 2022, 10:35
The rebuilder works fine, no ROM is lost.

Scenario: 241 dat, rebuild your roms, you end up with the 2 sets., Scan them, all fine.
Switch to 242 dat, scan with all fix options are enabled, yes, it seems that after that you're missing things, but in fact you will find 2 sets in the backup folder. Using the rebuilder to readd them works fine. Why scanner's fix missing does not automatically pick them up from backup..ok..that's a point to check though.

I don't see any "resize" attemp. The scanner reports missing and unneeded files to me.

You're using the latest cmpro version?
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: newuzer on 28 March 2022, 11:52
Yes, I'm using the latest version 4.044b.
If I load the attached XML and point it at the folder with the 2 sets,
the very first dialog I get when I scan with all fix options enabled:
Quote
Set:   Tokyo Joshikosei Sailor-fuku Nyumon Dai-2-kan
Name:   tokyojn2
File:   D:\temp\pc8801_flop\tokyojn2\tokyo joshikosei sailor-fuku nyumon dai2kan.d88

Wrong Size:   348848
Right Size:   348576

Do you want to resize the ROM?
Yes to all

Then:
Quote
Set:   Tokyo Joshikosei Sailor-fuku Nyumon Dai-2-kan
Name:   tokyojn2
File:   D:\temp\pc8801_flop\tokyojn2\tokyo joshikosei sailor-fuku nyumon dai2kan.d88

Do you want to remove the file?
Yes to all

Then:
Quote
Set:   Tokyo Joshikosei Sailor-fuku Nyumon Dai-3-kan
Name:   tokyojn3
File:   D:\temp\pc8801_flop\tokyojn3\tokyo joshikosei sailor-fuku nyumon dai3kan.d88

Do you want to add the missing ROM?
Yes to all

I end up with:
Quote
Tokyo Joshikosei Sailor-fuku Nyumon Dai-2-kan [folder: tokyojn2 - size: 340kb]
missing set: Tokyo Joshikosei Sailor-fuku Nyumon Dai-2-kan
missing rom: tokyo joshikosei sailor-fuku nyumon dai2kan.d88 [size: 348576] [CRC32: 1b66be31] [SHA1: bea94b35a43b402e9b8b8d1faefadc1cc7b1802a]

Tokyo Joshikosei Sailor-fuku Nyumon Dai-3-kan [folder: tokyojn3 - size: 341kb]
missing set: Tokyo Joshikosei Sailor-fuku Nyumon Dai-3-kan
missing rom: tokyo joshikosei sailor-fuku nyumon dai3kan.d88 [size: 348848] [CRC32: 870dbb9c] [SHA1: 08c07cb445dbfacc0086f6bde19b09bd11b09b34]

Rebuild from backup:
Quote
Analyzed Files:         2
Created Files:          1

Matched Files:          2
Skipped Files:          1

I end up with:
Quote
Tokyo Joshikosei Sailor-fuku Nyumon Dai-2-kan [folder: tokyojn2 - size: 340kb]
missing set: Tokyo Joshikosei Sailor-fuku Nyumon Dai-2-kan
missing rom: tokyo joshikosei sailor-fuku nyumon dai2kan.d88 [size: 348576] [CRC32: 1b66be31] [SHA1: bea94b35a43b402e9b8b8d1faefadc1cc7b1802a]

Regards, NU.
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: Roman on 28 March 2022, 13:26
I can't repeat that...

I get:
Set:   Tokyo Joshikosei Sailor-fuku Nyumon Dai-2-kan
Name:   tokyojn2
File:   E:\Temp\test2\tokyojn2\tokyo joshikosei sailor-fuku nyumon dai3kan.d88
Do you want to remove the file?

Set:   Tokyo Joshikosei Sailor-fuku Nyumon Dai-3-kan
Name:   tokyojn3
File:   E:\Temp\test2\tokyojn3\tokyo joshikosei sailor-fuku nyumon dai3kan.d88
Do you want to add the missing ROM?

Set:   Tokyo Joshikosei Sailor-fuku Nyumon Dai-3-kan
Name:   tokyojn3
File:   E:\Temp\test2\tokyojn3\tokyo joshikosei sailor-fuku nyumon dai2kan.d88
Do you want to remove the file?

And yes, after that one 1 file is missing, but everything is in backup and can be rebuilt from there.

Can you send me your *.cmp setting for your profile (cmpro's settings folder) and your cmpro.ini.
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: newuzer on 28 March 2022, 14:31
Settings attached, check PM.
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: Roman on 29 March 2022, 09:08
thanks for sending the files....I will have a look at it pretty soon.
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: Roman on 30 March 2022, 18:02
found the problem...fix is coming soon

The problem was that when the found missing file is added to the archive (where the same name exists), backup'ing the existing one failed due to a typo....this is fixed now. For the scenario it however means, that after scanning/fixing, you will still need to readd one file from backup via a rebuild operation (since it ends in an archive where fix missing does not look into...).
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: newuzer on 30 March 2022, 19:23
Yeah, rebuilding from backup is standard practice when something is missing ;)
Any idea where the mysterious resize I encountered, and you couldn't reproduce, came from?
It's a bit strange when we can't replicate the same behavior.

Thanks for taking the time to fix this.

Regards, NU.
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: Roman on 30 March 2022, 19:37
I was able to reproduce it with your files. Will check what is different
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: newuzer on 31 March 2022, 13:21
Thanks for the fixed version.
Besides my old configuration, I've also tested it with a newly generated cmpro.ini.
In both cases, the very first thing I got was the resize question.
The scan/fix/rebuild after that now went flawless.

N.B. The question for a resize of a ROM sounds weird (nasty) to me.
Not sure why it would even consider asking that.
In this case, it's just a swap/rename of 2 ROMs.
Can you enlighten me about the reason for the question?
What would it result in, besides deviating from the original dump?

Regards, NU.
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: Roman on 02 April 2022, 10:30
Don't worry about the resize. That's the normal behaviour when it sees that the file is there (identical name) but size is not correct.

Resize tries different things, not only cut down but also fill up with 0x00 / 0xff or double the rom to match the checksum.

So...ignore the message, the real problem was that when it adds the found missing rom, the existing one wasn't copied to backup.
Title: Re: pc8801_flop ROM shuffle scan/fix/rebuild fails
Post by: hayyeeji on 06 June 2022, 10:22
I don't see any "resize" attemp. The scanner reports missing and unneeded files to me.
hellodear.in (https://hellodear.in/)

teatv download (https://teatv.ltd/dl-now/)