EMULAB Forum

clrmamepro [English] => clrmame Discussion => Topic started by: GDT on 08 September 2020, 10:22

Title: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: GDT on 08 September 2020, 10:22
I get many "misplaced romset: (move to a rompath)" errors when scanning romset on MAME with latest nightly build (20200904). With stable version I don't get errors.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 08 September 2020, 11:31
Like? Some more details please.
What are you scanning? What are the exact messages...Did you use a previous nightly and you had no problems?
There is only one possibly related change in the nightly (and that's in the nightly since over a month already) and that's

fixed: some sets don't get marked as unneeded or weird renames are proposed in mame/software list combined mode only

...which may list some files which was not visible before..


So....more details please ;-)

I bet you're using the combined software list mode and the reported ones are actually the ones which were overseen before....so would be interesting to see the datails. and yes...the message "move to a rompath" might be a bit misleading...will change that as soon as I got some time
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: GDT on 08 September 2020, 12:39
Just ended to scan my romset with stable version with no problems.
I use full software list mode, not combined. If I rebuild the software list with rebuilder it will add the romsets highlighted with the error.
It refers to many romsets inside "electron_cass" software list, one romset inside "g7400" software list and one inside "ibm5150" softwarelist.

This is a partial list of the highlighted sets inside "electron_cass":
9cardbd1.7z
9cardbd2.7z
abgensnr.7z
abyss.7z
advcreat.7z
artstudi.7z
aufwiede.7z
axeofkol.7z
battlefi.7z
bridgema.7z
...
...
...

skyhawk.7z
specops.7z
spoker2p.7z
sporttri.7z
starques.7z
survivrs.7z
terrormo.7z
tetris.7z
theboss.7z
thequill.7z
topstail.7z
triple7.7z
turfform.7z
vegasjac.7z
weetabix.7z
wychwood.7z
xanagram.7z

I use merged romsets compressed with 7zip. Thank you for support and for the great work.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 08 September 2020, 13:43
But as you can check by looking at MAME's hash folder, the electron_cass does not have such sets listed. They belonge to "electron_flop" (and others)

So...they don't belong there and cmpro is right :)

and I think your "full software list mode" is my "combined mode", i.e. you have only one profile for MAME and all/subset of its software lists and not one profile per softwarelist, am I right?
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: GDT on 08 September 2020, 18:05
and I think your "full software list mode" is my "combined mode", i.e. you have only one profile for MAME and all/subset of its software lists and not one profile per softwarelist, am I right?

You're right: one profile and multiple rom paths setted in.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 08 September 2020, 18:49
Yeah and in that mode earlier cmpro versions did oversee some misplaced sets which is now fixed.
Guess I need to improve the failure message a bit.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: GDT on 09 September 2020, 07:49
Ok thanks, I just rescanned with nightly and deleted the highlighted files from the romsets. Scanned ended without errors but I noticed that there are some roms inside romsets that still will be manteined and doesn't give any warning.
For example, I get warning aboute "triple7" romset inside electron_cass software list, but got no warning for triple1, triple2 etc... which are included (wrongly) inside the romset (only triple8 is in the right place, the others need to stay inside bbc_cass software list). So I suppose that there are still some sets which is not recognized as wrong.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 09 September 2020, 08:23
yes, I'm aware of that (thanks anyway) and working on it
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: GDT on 09 September 2020, 13:30
Thank you for your hard work.

If it can help I found another software list which is wrongly intrepeted: some "pippin" chds are marked as in wrong rompath but they are in the right place:

misplaced romset: \pippin\aishogi (move to a rompath)
misplaced romset: \pippin\catalog (move to a rompath)
misplaced romset: \pippin\chisatom (move to a rompath)
misplaced romset: \pippin\circus (move to a rompath)
misplaced romset: \pippin\compton (move to a rompath)
misplaced romset: \pippin\gadget (move to a rompath)
misplaced romset: \pippin\lzone (move to a rompath)
misplaced romset: \pippin\music1 (move to a rompath)
misplaced romset: \pippin\sdgundam (move to a rompath)
misplaced romset: \pippin\shockwav (move to a rompath)
misplaced romset: \pippin\supermar (move to a rompath)
misplaced romset: \pippin\tamagotc (move to a rompath)
misplaced romset: \pippin\thomas (move to a rompath)
misplaced romset: \pippin\ultraman (move to a rompath)
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 09 September 2020, 19:31
https://mamedev.emulab.it/clrmamepro/binaries/cmpro20200909.7z

That should detect things like triple1 etc plus there was a problem with parent/clonerelationships in software list roms/chds in combined mode.
I wasn't able to repeat your pippin messages. Let me know if you still experience them.

....and I will try to make the "(move to a rompath)" more informative or fixable as soon as I find a little time
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: GDT on 09 September 2020, 22:21
I just tested the new build and it deleted many roms inside romsets, mainly neogeo roms, for almost a gigabyte of data. No more pippin romset issue, too.

Thank you!
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 10 September 2020, 05:54
I bet these were the ones related to the parent/clone merge bug which was fixed. In combined mode it did detect parent/clone relationships between sets though but the actual parent files in the clone sets weren't marked as belonging to the parent...so you had the dupes in there which now got removed.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: llagos on 03 October 2020, 01:31
Ciao Roman,
Just updated mame to .225, and also cmpro to latest 20200924. Also have a "combined" set (just 1 profile for mame with all standard/sw/bios romsets). After updating both exe and profile, I did a scan with all Fix's set.
I also have lots of these messages. Attached log zipfile.
Could You take a look at it please?
Gracias!
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 03 October 2020, 09:27
As mentioned before, cmpro is correct to report such unneeded sets.
These are sets which belong to a different softwarelist. Most likely you already have them in the right software list, so you can kill them.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: llagos on 03 October 2020, 12:33
Thanks Roman... one follow up question... then... could cmpro delete them? I already check "fix unneeded" in the scanner...
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 03 October 2020, 12:38
I'm working on a better solution than just saying "move to a rompath" (e.g. moving them to the correct software list path or deleting them).
Till then, you might be able to use the contextmenu "move" or "delete" options to get rid of them.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: llagos on 03 October 2020, 13:18
great! In the meantime, I moved all "misplaced" zips to another folder, and the used Rebuild on them...
L:\sw\tmp\zips\misplaced\homecomp.7z\z80_c7420.bin
  [EXISTS: homecomp\z80_c7420.bin]
L:\sw\tmp\zips\misplaced\homecomp.7z\vp_c7420.bin
  [EXISTS: homecomp\vp_c7420.bin]

L:\sw\tmp\zips\misplaced\infernal.zip\la ruche infernale (france).bin
  [EXISTS: infernal\vp_52pl_f.bin]

L:\sw\tmp\zips\misplaced\interpol.zip\interpol (europe) (proto).bin
  [EXISTS: interpol\pr_interpol.bin]

It seems most of them are bad names? not sure... The first messages are same name, same folder, but it doesn't say the software list... maybe adding the software list name could provide better clarity :)

Again, thanks for such a great work!
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 03 October 2020, 14:37
The rebuilder log simply says what was expected. You already got the files in the correct destination folder. No need to re-add them.
You only had dupes in the wrong softwarelist paths before, you moved them to a temp place and then you tried to readd them to the correct place ...where they already exist.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: mimoluo on 29 November 2021, 05:57
Surprisingly found the same issue still happening in the latest release

Following my issue here:
https://www.emulab.it/forum/index.php?topic=5273.msg21178#msg21178

My observation from the behavior of clrmamepro concludes that: the scanner/rebuilder does not seriously treat the manually assigned system ROM paths for software-lists, and implicitly assign a destination path unexpected by the user. 

In my case, the rebuilder undesirably creates software-listed roms in $mameroot\software instead of $mameroot\software\$mycustomed_system_path, and when the scanner does the checking, the created roms are deemed as "misplaced", generating a significant amount of error messages without the capability to move them to the correct place.

I am not sure if it is technically hard to add some intellegence in defining the rom paths.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 29 November 2021, 07:02
"In my case, the rebuilder undesirably creates software-listed roms in $mameroot\software instead of $mameroot\software\$mycustomed_system_path"

It sounds like you have $mameroot\software as a rompath which is wrong if you also have subfolders in there for the single softwarelists.
Rompaths can't contain rompaths. Please check your setup again.
If you like I can have a look at your setup if you send me your *.cmp file for your used profile (cmpro settings folder) plus cmpro.ini.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: mimoluo on 29 November 2021, 07:33
Thanks for your prompt answer, Roman,

I kind of found the reason why my configuration did not work.

The system paths require a "\" at the end.
for exmaple:
wrong: O:\Games\Emulator\Mame\Software\wizard_cart
correct: O:\Games\Emulator\Mame\Software\wizard_cart\

When I redo the configuration, sl roms go to the right places as expected.
It will be nice to have a smart wizard aiming at this kind of issues.
Title: Re: Many "misplaced romset: (move to a rompath)" on latest nightly 20200904
Post by: Roman on 29 November 2021, 08:06
hmm....but cmpro always writes its selected paths with a \ at the end.....so I wonder how you get paths without it (unless manually editing *.cmp files which is not recommended :) ).