EMULAB Forum

clrmamepro [English] => clrmame Discussion => Topic started by: oddi on 08 December 2018, 16:46

Title: may found bug
Post by: oddi on 08 December 2018, 16:46
Hello Roman, see what bug found :
when updated mame source in cmpro, cmpro replace old dat with new dat file but in profile window i see both dat files, old and new !
cmpro folder after replace:
(http://store.picbg.net/pubpic/2F/E6/db0774decb892fe6.jpg)

cmpro profile window:
(http://store.picbg.net/pubpic/DA/3E/afdf9ece3c23da3e.jpg)

used the last forum build :)
and upload 2 dats for test

https://www4.zippyshare.com/v/HLCUdoxR/file.html (https://www4.zippyshare.com/v/HLCUdoxR/file.html)
https://www4.zippyshare.com/v/SCWWxIBJ/file.html (https://www4.zippyshare.com/v/SCWWxIBJ/file.html)


Title: Re: may found bug
Post by: Roman on 08 December 2018, 17:06
Thanks for reporting. I will have a look for now hit refresh.
Title: Re: may found bug
Post by: Roman on 10 December 2018, 20:48
should be fixed...
http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181210.rar (http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181210.rar)
Title: Re: may found bug
Post by: oddi on 11 December 2018, 16:05
Show must go on :)

Roman, if put file in any other folder before cmpro update window see result:
duplicate folder structure, first MAME folder have dat
(http://store.picbg.net/pubpic/98/E9/03a21cc1054b98e9.jpg)

second folder MAME:
(http://store.picbg.net/pubpic/6F/D6/473814ae233e6fd6.jpg)
is empty.

here all is fine :
(http://store.picbg.net/pubpic/4D/8E/5c0286fa2fec4d8e.jpg)

Now my cmpro it's broken ..and not have backup exe ...of course.
I'm Jedi :)

P.S.
Now restore 4.35 exe - all is fine with visualisation

Title: Re: may found bug
Post by: Roman on 11 December 2018, 22:33
hmmm...can't repeat this....what did you actually do? Can you describe it step by step, like, what was the initial folder structure, how and where did you add the first file, how/where did you place the update file etc....
Title: Re: may found bug
Post by: oddi on 12 December 2018, 09:44
Tested with:
Clean cmpro4.35 x86 or x64 , take exe from the forum build and replace over 4.35.
Create folder "1" and add inside first mame dat: mame0204-179-ge754e43586.xml,
load dat , all warnings and etc etc, do not load roms folders, samples .
Open scanner window and close scanner window and back in Profiles folder .

Atm all is fine , looking "1/mame0204-179-ge754e43586.dat"
Now create new folder "2" and put dat: mame0204-199-g4345e8d455.xml in folder 2 .
Now have "[NEW DATFILES] 2/ mame0204-199-g4345e8d455"
double click over dat and next window "No Settings Found" click Update button, next window "Update Settings"  check "1/mame0204-179-ge754e43586" and Update button .
Again load dat , all warnings and etc etc., open Scanner ( do not start) , close scanner and back to Profiles folder and see problem :
have two folders "1" and one folder "2"
first "1" it's empty
second: have dat
"2" - of course is empty

Never see this problem before .

From many years ago i used this method for update mame dats :
Drag and drop dat in any folder ( not looking )
and with dialog windows "No Settings found" and "Update settings" updated old dat .
Hope u understand me :)

P.S.
Noticed , if start the first time cmpro and create folder ( not loaded dat ,nothing ), folder it's not see.
When add first dat i looking folder.
Do not remember that bug or cmpro features. :)
Title: Re: may found bug
Post by: Roman on 12 December 2018, 21:13
http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181212.rar (http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181212.rar)

;-)

thanks for your reports by the way....
Title: Re: may found bug
Post by: oddi on 13 December 2018, 09:29
Hmmm, atm all is fine , wait the next bug wave :P

Thank you so much Roman :)


Pffff, not solved , problem it's stay

Now load new SL dat and same story - double folders
attach new xml for test
Title: Re: may found bug
Post by: Roman on 13 December 2018, 10:01
Eh? Nope..not here. All folders remain as they should...

So..what did you do exactly again? ;-)
Let's start with your Folder 1 / 2 example again....and then you add the new dat where? And what do you do then?

Title: Re: may found bug
Post by: oddi on 13 December 2018, 10:22
Yes, try with folder 1 and 2
 add xml in 1 and load , open scanner and close, back to profile
add same xml to folder 2 and load , updated 1/monon_color.xml
and see result :
folder 1 : 2 dats with same names
folder 2 : empty ( of course )
:)
p.s. opsss , not effect with double folders, have double dats . Sorry, my mistake !
I'm tottaly lost again.,.. because this "speedy gonzales" feature broken my favorite tool :)
Title: Re: may found bug
Post by: Roman on 13 December 2018, 12:04
ah...double files...not folders...ok...I will have a look ;-)
who in the world uses equally named files ;-)
Title: Re: may found bug
Post by: Roman on 13 December 2018, 19:59
guess what...

http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181213.rar (http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181213.rar)
Title: Re: may found bug
Post by: oddi on 14 December 2018, 14:51
Copy-paste my previous post :)

Quote
Hmmm, atm all is fine , wait the next bug wave :P

Thank you so much Roman :)
Title: Re: may found bug
Post by: oddi on 16 December 2018, 19:04
PART II:

Roman , new bug with nightly build in batch mode :
Now start rebuild mame stuffs from new ProgettoSnaps sets and:
when finish scan cmpro report:"-not scanned yet-"
(give example with icons sets)
(http://store.picbg.net/pubpic/E7/F5/0a4b84edd034e7f5.jpg)
if manually scan set - all is fine
with 4.35 not have this problem
Thank you :)

P.S. Here have dats: http://www.progettosnaps.net/dats/ (http://www.progettosnaps.net/dats/)
Test with which sets u wanna , result it's same

P.S.1 : PART IIa:
Batch mode is hardcore for cmpro - freeze when scan big  sets : snaps, manuals
Now with 4.35 restart batch mode and fix my ProggetoSnaps sets

No problem in cmpro:)
Title: Re: may found bug
Post by: Roman on 17 December 2018, 07:03
Tadaa

http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181217.rar (http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181217.rar)
Title: Re: may found bug
Post by: oddi on 19 December 2018, 16:24
Uncle oddi say: it's worked !!! :)
Title: Re: may found bug
Post by: oddi on 21 December 2018, 17:05
PART III

cmpro last "nightly" build :)

2 vizualization bugs:

1. Mame status :
(http://store.picbg.net/pubpic/2A/CB/9fd9d43931de2acb.jpg)
After update mame source all is fine with status, few days later start cmpro and see above image:

2. Add few SL dats ( 15-20 XML FOR TEST ) in [PROFILES] ,  start batch mode with "No Rebuilder Run" ->
my MAME SL have in [PROFILES]/MAME/MAME_SoftwareList/
When start batch mode we looking :
or cmpro "forget: few sets:

(http://store.picbg.net/pubpic/C2/C0/ebbdaae5fe67c2c0.jpg)

or stay on "white screen"
(http://store.picbg.net/pubpic/87/07/8f4e4c6b086e8707.jpg)

and when click "X" cmpro continues scan batch mode with "forget effect" again :)

Try with more dats - 15-20
the next year may have any final build  :P :P :P


P.S.
Restart cmpro after my post and have "new" mame status:

(http://store.picbg.net/pubpic/39/EB/a62e3a98acff39eb.jpg)
Title: Re: may found bug
Post by: Roman on 21 December 2018, 23:45
http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181222.rar (http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181222.rar)
Title: Re: may found bug
Post by: oddi on 23 December 2018, 03:45
canary build: cmpro20181222.rar

Use only scan mame set:

cmpro self move subfolders !
(http://store.picbg.net/pubpic/E9/7A/ba07f41f3895e97a.jpg)


move "MAME_SoftwareList" and "progetto-SNAPS" from "MAME" folder to "FIX" folder
and......
 create under "MAME" new subfolder "SoftwareList"
looks result:
(http://store.picbg.net/pubpic/E0/6B/28e82aae47d0e06b.jpg)
cmpro restore subfolders to original position:)

If remove "SoftwareList" , others folders again move to "FIX"



Title: Re: may found bug
Post by: Roman on 23 December 2018, 15:47
http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181223.rar (http://mamedev.emulab.it/clrmamepro/binaries/cmpro20181223.rar)
Title: Re: may found bug
Post by: oddi on 31 December 2018, 18:05
Few hours to 2019 :)
"New Year" bugs , 2 times:
SL+batchmode:
Stored SL dats in [PROFILES]/MAME/SL
And  have new or update SL dats , if put new and update SL dats in any other folder and start batch mode with disable "No Rebuilder Run" :
cmpro found correct original path , examples: [PROFILES]/MAME/SL
but with 2 bugs :
1. Not change date of new SL dats
2. If have missing sets cmpro ingore that and report all it's green circles. ( very bad bug )

If added SL dats in correct stored pats ,examples : [PROFILES]/MAME/SL, all it's perfect after batch mode :
1. correct date
2. red circle for missing sets

Here is 20:04 and i'm back to other room, see u next year :)

Title: Re: may found bug
Post by: Roman on 01 January 2019, 11:24
Yeah, I've spotted that one (not updating the stats incl. red/green dot) some days ago already....didn't look at it yet though...Happy New Year
Title: Re: may found bug
Post by: Roman on 03 January 2019, 22:25
http://mamedev.emulab.it/clrmamepro/binaries/cmpro20190103.rar (http://mamedev.emulab.it/clrmamepro/binaries/cmpro20190103.rar)
Title: Re: may found bug
Post by: oddi on 19 January 2019, 17:37
Hi Roman, all it's fine with the last canary build :)
batch mode, date, put in differents folder - whole is perfect

But...explain me this problem or not :
look this commit https://github.com/mamedev/mame/commit/b7bea7a50f5372d3e5bf7ead5aa34a2cfd23b699 (https://github.com/mamedev/mame/commit/b7bea7a50f5372d3e5bf7ead5aa34a2cfd23b699)
set is rad_rsg
(http://store.picbg.net/pubpic/0E/82/621706e5b7840e82.jpg)
have 2 sets with same roms

cmpro show :
(http://store.picbg.net/pubpic/CB/EF/88cf94d8abf1cbef.jpg)

when rebuild cmpro build only main set rad_rsg with rom without subfolder rad_rsgp with same rom

This normal or I am confusing something ?

Upload set here : https://www43.zippyshare.com/v/24cX9hZd/file.html (https://www43.zippyshare.com/v/24cX9hZd/file.html)
Thank you :)

Title: Re: may found bug
Post by: Roman on 19 January 2019, 19:00
do you have a current datfile handy?

identical sets are not that uncommon...there is for example natodef and natodefa in MAME since ages....and they (both) should rebuild fine
Title: Re: may found bug
Post by: oddi on 19 January 2019, 19:25
U right , now look natodef and natodefa - same story , two sets in dat with same checksums , one archive without subfolder
(http://store.picbg.net/pubpic/93/DA/2dacdf22e5b093da.jpg)
cmpro merged this sets

upload here dat from this commit hash a143090d103584a1aedcb2939f1db740d10ff935:

https://www70.zippyshare.com/v/OLvDl2Md/file.html (https://www70.zippyshare.com/v/OLvDl2Md/file.html)

Maybe that is false alarm ,who know :)
May all right with natodef and rad_rsg , i dont know how cmpro read this sets :)



Title: Re: may found bug
Post by: Roman on 19 January 2019, 20:25
well, these 2 rad_rsg sets are in a parent/clone relationship, so if you have split or full merged sets, you will end with 1 set only since their roms are fully shared....the "clone" will disappear...which is perfectly fine.

In profiler options you got an option to not create "fake clones"....this is enabled by default...if you disable it and rebuild the set again, you will end up with 2....(however the scanner won't complain if you only have the one set..)...it's not recommended to turn this option off....


so...nothing new...nothing wrong....
Title: Re: may found bug
Post by: oddi on 19 January 2019, 21:12
Thank you Roman for your amazing job :)
atm - sleep calm :)