clrmamepro [English] > clrmame Discussion

Bug/Suggestion: Fix Unneeded

(1/1)

MsJamie:
I'm not so sure this is a bug; probably more a PEBKAC* error...

I was cleaning up a directory, preparing to download an update.  A scan showed ~30-40 unneeded files.  I didn't want to delete them or mix them in with my MAME files, so I created a new subdirectory, 'unneeded', in the directory I was scanning.

Yes, you can see where this is headed.  Hey, I just got up and hadn't had my coffee yet.  Besides, I do remember this working before.

I enable 'Fix Unneeded', click Yes to a couple files.  It's working fine.  I click 'Yes to All' and get a popup saying something like "Cannot move Unneeded" or something like that.

Then, my Unneeded folder is empty except for one file.

All but one of the files flagged as unneeded sucked out into the Nether.  Not even Norton Unerase can find any trace of them.

Yes, I did a stupid.  Never underestimate the ability of a code monkey to do something stupid before she has her morning coffee.

The suggestion?  Put a "sanity check" when starting a Fix Unneeded scan, and alert the user if the backup directory falls within the scan range.

* Problem Exists Between Keyboard And Chair

Roman:
The "Fix unneeded" operation moves the files to the cmpro backupfolder.
No idea what you mean with "unneeded folder".

MsJamie:
Assume the files I was fixing are in C:\Foo, and I had set the backup directory to C:\Foo\Unneeded.

I then proceeded to scan, with Fix Unneeded checked.

When it scanned C:\Foo, it (properly) scanned C:\Foo\Unneeded as well.  When it tried to move the unneeded file C:\Foo\Unneeded\Bar.zip to C:\Foo\Unneeded\Bar.zip (the same location), it ended up deleting the file.

Hope this helps explain the situation.

Roman:
Argh, don't set the backupfolder as a rompath subfolder!!!!!

Cmpro supports decompressed sets. They follow the storing method: rompath\setname\file 1... file n

So your just created rompath subfolder is detected as an unneeded set and moved to backup...which is again the same folder.....and this creates a hole in the time-space continuum. Put your backupfolder somewhere else and I will add a check if someone got the weird idea to use the rompath or a rompath subfolder as backup.... :)

Navigation

[0] Message Index